From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: Re: mwx: argument order fix for m_gethdr
To: Kevin Lo <kevlo@kevlo.org>
Cc: tech@openbsd.org
Date: Sun, 16 Feb 2025 13:01:35 +0100

On Sun, Feb 16, 2025 at 05:00:28PM +0800, Kevin Lo wrote:
> Stumbled upon it while reading code.
> 
> ok?

Sure. OK claudio@
 
> Index: sys/dev/pci/if_mwx.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/if_mwx.c,v
> diff -u -p -u -p -r1.5 if_mwx.c
> --- sys/dev/pci/if_mwx.c	22 May 2024 16:24:59 -0000	1.5
> +++ sys/dev/pci/if_mwx.c	16 Feb 2025 08:45:54 -0000
> @@ -2215,7 +2215,7 @@ mwx_mcu_alloc_msg(size_t len)
>  	struct mbuf *m;
> 
>  	/* Allocate mbuf with enough space */
> -	m = m_gethdr(MT_DATA, M_DONTWAIT);
> +	m = m_gethdr(M_DONTWAIT, MT_DATA);
>  	if (m == NULL)
>  		return NULL;
>  	if (len + headspace > MHLEN) {
> 

-- 
:wq Claudio