From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgpd: split out mrt capture in SE
To: tech@openbsd.org
Date: Tue, 18 Feb 2025 15:51:11 +0100

On Tue, Feb 18, 2025 at 03:37:56PM +0100, Claudio Jeker wrote:
> I want to start splitting up session.c into smaller files.
> One part I want split out is the message processing code and for that
> mrt logging needs to be its own function since I don't want to export
> the mrt head.
> 
> So this diff does that.

ok tb

> +	LIST_FOREACH(mrt, &mrthead, entry) {
> +		if (!(mrt->type == MRT_ALL_IN || mrt->type == MRT_ALL_OUT))
> +			continue;

Might want to apply De Morgan here to make this closer to
session_mrt_dump_bgp_msg():

		if (mrt->type != MRT_ALL_IN && mrt->type != MRT_ALL_OUT)
			continue;

Whichever way you prefer is fine.