From: Marcus Glocker <marcus@nazgul.ch>
Subject: Re: sys/uvideo: dump baInterfaceNr when debug is enabled
To: "Kirill A. Korinsky" <kirill@korins.ky>
Cc: tech@openbsd.org
Date: Sun, 23 Feb 2025 09:19:33 +0100

On Tue, Feb 18, 2025 at 11:52:08PM GMT, Kirill A. Korinsky wrote:

> tech@,
> 
> I'd like to improve a bit uvideo_dump_desc_vc_header by dumping all
> baInterfaceNr.
> 
> Ok?

ok mglocker@
 
> Index: sys/dev/usb/uvideo.c
> ===================================================================
> RCS file: /home/cvs/src/sys/dev/usb/uvideo.c,v
> diff -u -p -r1.238 uvideo.c
> --- sys/dev/usb/uvideo.c	15 Feb 2025 09:05:15 -0000	1.238
> +++ sys/dev/usb/uvideo.c	18 Feb 2025 12:02:23 -0000
> @@ -2617,10 +2617,14 @@ void
>  uvideo_dump_desc_vc_header(struct uvideo_softc *sc,
>      const usb_descriptor_t *desc)
>  {
> +	int i;
> +	uByte *baInterfaceNr;
>  	struct usb_video_header_desc *d;
>  
>  	d = (struct usb_video_header_desc *)(uint8_t *)desc;
>  
> +	baInterfaceNr = (uByte *)(d + 1);
> +
>  	printf("bLength=%d\n", d->bLength);
>  	printf("bDescriptorType=0x%02x\n", d->bDescriptorType);
>  	printf("bDescriptorSubtype=0x%02x\n", d->bDescriptorSubtype);
> @@ -2628,6 +2632,8 @@ uvideo_dump_desc_vc_header(struct uvideo
>  	printf("wTotalLength=%d\n", UGETW(d->wTotalLength));
>  	printf("dwClockFrequency=%d\n", UGETDW(d->dwClockFrequency));
>  	printf("bInCollection=0x%02x\n", d->bInCollection);
> +	for (i = 0; i < d->bInCollection; i++)
> +		printf("baInterfaceNr[%d]=0x%02x\n", i, baInterfaceNr[i]);
>  }
>  
>  void
>