From: Kirill A. Korinsky <kirill@korins.ky>
Subject: sys/uvideo: dump bDescriptorSubtype for unsupported CS_INTERFACE when debug is enabled
Cc: OpenBSD tech <tech@openbsd.org>, Marcus Glocker <mglocker@openbsd.org>
Date: Sun, 23 Feb 2025 11:20:52 +0100

tech@,

I'd like to improve a bit uvideo_dump_desc_vc_header by dumping all
bDescriptorSubtype for unsupported CS_INTERFACE.

Ok?

Index: sys/dev/usb/uvideo.c
===================================================================
RCS file: /home/cvs/src/sys/dev/usb/uvideo.c,v
diff -u -p -r1.239 uvideo.c
--- sys/dev/usb/uvideo.c	23 Feb 2025 08:28:57 -0000	1.239
+++ sys/dev/usb/uvideo.c	23 Feb 2025 10:16:04 -0000
@@ -2557,6 +2557,12 @@ uvideo_dump_desc_all(struct uvideo_softc
 				printf("|\n");
 				uvideo_dump_desc_colorformat(sc, desc);
 				break;
+			default:
+				printf("bDescriptorSubtype=0x%02x",
+				    desc->bDescriptorSubtype);
+				printf(" (unknown)\n");
+				break;
+
 			}

 			break;