From: Bryan Vyhmeister <bryan@bsdjournal.net>
Subject: Re: [PATCH] SK hynix P31 and P41 NVMe add to pcidevs
To: Theo de Raadt <deraadt@openbsd.org>
Cc: tech@openbsd.org, Hrvoje Popovski <hrvoje@srce.hr>
Date: Wed, 5 Mar 2025 18:03:42 -0800

On Wed, Mar 05, 2025 at 06:36:29PM -0700, Theo de Raadt wrote:
> Bryan Vyhmeister <bryan@bsdjournal.net> wrote:
> 
> Does not need to say NVME
> 
> That is wasting bytes.  Look at your dmesg to see how it looks.

Good point. Updated diff below. Should I fix all the Samsung IDs that
have NVMe on the end?

Bryan


Index: sys/dev/pci/pcidevs
===================================================================
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
diff -u -p -r1.2097 pcidevs
--- sys/dev/pci/pcidevs	19 Feb 2025 10:38:14 -0000	1.2097
+++ sys/dev/pci/pcidevs	6 Mar 2025 01:27:08 -0000
@@ -9275,7 +9275,10 @@ product SIS 966_HDA		0x7502	966 HD Audio
 /* SK hynix products */
 product SKHYNIX BC501		0x1327	BC501
 product SKHYNIX PC601		0x1627	PC601
+product SKHYNIX SHGP31		0x174a	Gold P31
+product SKHYNIX SHPP41		0x1959	Platinum P41
 product SKHYNIX BC901		0x1d59	BC901
+product SKHYNIX PE8000		0x2839	PE8000
 
 /* SMC products */
 product SMC 83C170		0x0005	83C170