From: Hans-Jörg Höxer <hshoexer@genua.de>
Subject: Re: [EXT] Re: SEV-ES: respect minimum ASID value
To: <tech@openbsd.org>
Date: Wed, 30 Apr 2025 10:42:41 +0200

Hi,

On Tue, Apr 29, 2025 at 01:56:04PM -0400, Dave Voutila wrote:
> > @@ -710,6 +711,7 @@ identifycpu(struct cpu_info *ci)
> >  		    'd', CPUID_MEMBER(ci_feature_amdsev_edx),
> >  		    CPUID_AMDSEV_EDX_BITS);
> >  		amd64_pos_cbit = (ci->ci_feature_amdsev_ebx & 0x3f);
> > +		amd64_min_noes_asid = (ci->ci_feature_amdsev_edx);
> 
> The parens look strange here because they're not guarding
> anything. Maybe it's just the context of the diff hunk, but given no
> bitwise ops can we drop them?


indeed, these are odd, sorry for that.   And bluhm@ already took care :)
Thanks!

Take care,
HJ.