From: Stefan Sperling <stsp@stsp.name>
Subject: Re: ure(4): add support for RTL8157
To: Kevin Lo <kevlo@kevlo.org>
Cc: tech@openbsd.org
Date: Fri, 16 May 2025 18:15:28 +0200

On Thu, May 15, 2025 at 02:57:11PM +0800, Kevin Lo wrote:
> On Thu, May 08, 2025 at 02:55:52PM +0800, Kevin Lo wrote:
> >
> > Hi,
> >
> > This diff adds preliminary support for RTL8157 to ure(4).
> > The RTL8157 is a USB 3.0 device which supports 10/100/1000/2500/5000Mbps speeds.
> >
> > Tested:
> > ure0 at uhub1 port 1 configuration 1 interface 0 "WisdPi USB 5G Ethernet" rev 2.10/30.00 addr 2
> > ure0: RTL8157 (0x1030), address 34:c8:d6:xx:xx:xx
> 
> Below is a revised diff that checks the return values of
> ure_{rtl8153,rtl8153b,rtl8157}_init and ure_{rtl8152|rtl8153}_nic_reset.
> 
> In addition, moid@ suggests that it would be better for
> ure_rtl8157_ocp_reg_read to return 0 or 0xffff if the i == 10 code path are hit.
> 
> Tests and feedback welcome.

Tested on two 8153 devices, works fine.

ure0 at uhub4 port 2 configuration 1 interface 0 "Lenovo Thinkpad USB LAN" rev 3.00/30.00 addr 2
ure0: RTL8153 (0x5c20), address xx:xx:xx:xx:xx:xx
rgephy0 at ure0 phy 0: RTL8251, rev. 0

ure0 at uhub4 port 2 configuration 1 interface 0 "Realtek USB 10/100/1000 LAN" rev 3.00/30.00 addr 2
ure0: RTL8153 (0x5c30), address xx:xx:xx:xx:xx:xx
rgephy0 at ure0 phy 0: RTL8251, rev. 0