From: Vitaliy Makkoveev <mvs@openbsd.org>
Subject: Re: ip6_mroute: add missing counter
To: Jan Klemkow <jan@openbsd.org>
Cc: tech@openbsd.org
Date: Tue, 20 May 2025 12:24:18 +0000

On Tue, May 20, 2025 at 03:58:08AM +0200, Jan Klemkow wrote:
> Hi,
> 
> This diff add two missing/unused counters in IPv6 multicast routing
> code.  We use the same counters at these places in the IPv4 version.
> 
> ok?
> 

ok mvs

> bye,
> Jan
> 
> Index: netinet6/ip6_mroute.c
> ===================================================================
> RCS file: /cvs/src/sys/netinet6/ip6_mroute.c,v
> diff -u -p -r1.146 ip6_mroute.c
> --- netinet6/ip6_mroute.c	19 May 2025 04:54:04 -0000	1.146
> +++ netinet6/ip6_mroute.c	20 May 2025 01:54:12 -0000
> @@ -936,6 +936,7 @@ ip6_mforward(struct ip6_hdr *ip6, struct
>  	/*
>  	 * Determine forwarding mifs from the forwarding cache table
>  	 */
> +	mrt6stat_inc(mrt6s_mfc_lookups);
>  	rt = mf6c_find(NULL, &ip6->ip6_dst, rtableid);
>  
>  	/* Entry exists, so forward if necessary */
> @@ -948,6 +949,7 @@ ip6_mforward(struct ip6_hdr *ip6, struct
>  		 * send message to routing daemon
>  		 */
>  
> +		mrt6stat_inc(mrt6s_mfc_misses);
>  		mrt6stat_inc(mrt6s_no_route);
>  
>  		{
>