From: Theo Buehler <tb@theobuehler.org>
Subject: Re: dhcpd(8): don't avoid free()
To: David Gwynne <david@gwynne.id.au>
Cc: tech@openbsd.org
Date: Sat, 31 May 2025 06:33:16 +0200

On Sat, May 31, 2025 at 11:48:24AM +1000, David Gwynne wrote:
> On Fri, May 30, 2025 at 07:43:37AM +0200, Theo Buehler wrote:
> > On Fri, May 30, 2025 at 03:28:54PM +1000, David Gwynne wrote:
> > > dhcpd seems to keep it's own free lists for a couple of data
> > > structures.  my best guess for why it would do this is to avoid
> > > malloc overhead.  however, responding to dhcp packets is not what
> > > i would consider a webscale problem^W^W^Wperformance critical, so
> > > this optimisation is unecessary.
> > > 
> > > ok?
> > 
> > ok
> > 
> > Are you going to remove the free_timeouts list as well?
> 
> like this?

Yes. You could consider changing the break in cancel_timeout() to a
return but it doesn't really matter.