From: Theo Buehler <tb@theobuehler.org>
Subject: Re: rpki-client: cleanup mutexes and conditional variables
To: Job Snijders <job@openbsd.org>, tech@openbsd.org
Date: Tue, 24 Jun 2025 07:47:17 +0200

On Tue, Jun 24, 2025 at 07:41:28AM +0200, Claudio Jeker wrote:
> On Tue, Jun 24, 2025 at 07:38:34AM +0200, Theo Buehler wrote:
> > On Tue, Jun 24, 2025 at 07:30:27AM +0200, Claudio Jeker wrote:
> > > On Mon, Jun 23, 2025 at 11:25:30PM +0000, Job Snijders wrote:
> > > > Free the pthreads mutex and conditional variable memory allocations.
> > > > Spotted by tb@
> > > > 
> > > > OK?
> > > 
> > > All of those use static initalisation. So it is unclear to me if this
> > > works on all systems. Documentation is very unclear here.
> > 
> > POSIX seems explicit enough:
> > 
> > "The effect shall be equivalent to dynamic initialization by a call to
> > pthread_cond_init() with parameter attr specified as NULL."
> > 
> > Similarly for pthread mutexes.
> 
> In that case, OK.

I agree, but if we do this, auth_tree_free() and crl_tree_free() should
also destroy the rwlocks.