From: Hrvoje Popovski Subject: Re: bge/bnx/iavf/igc/ix/ixl/ngbe/pcn: ifq_restart() fix To: Alexander Bluhm , tech@openbsd.org, Stefan Sperling Date: Thu, 26 Jun 2025 14:39:11 +0200 On 24.6.2025. 13:16, Stefan Sperling wrote: > On Mon, Jun 23, 2025 at 08:04:06PM +0200, Alexander Bluhm wrote: >> And what should we do with the drivers noone has hardware and wants >> to test? Just commit? > > Only bnx and pcn have not yet been committed. Relevant diffs below. > > It should be fairly safe to commit these changes but I will still > wait a little while just in case someone is going to test them soon. Hi, I've tested this diff with plain forwarding over bnxt and it seems to work just fine. I'm sending traffic from host connected to bnxt0 to host connected to bnxt1 smc24# kstat bnxt0::: bnxt0:0:rxq:0 packets: 81810387 packets bytes: 4908627774 bytes fdrops: 0 packets qdrops: 41350286 packets errors: 0 packets qlen: 0 packets enqueues: 1092225 dequeues: 38707 bnxt0:0:rxq:1 packets: 103918832 packets bytes: 6235130140 bytes fdrops: 0 packets qdrops: 27998284 packets errors: 0 packets qlen: 0 packets enqueues: 1618533 dequeues: 68453 bnxt0:0:rxq:2 packets: 85048401 packets bytes: 5102904060 bytes fdrops: 0 packets qdrops: 39622523 packets errors: 0 packets qlen: 0 packets enqueues: 1154626 dequeues: 53349 bnxt0:0:rxq:3 packets: 84310230 packets bytes: 5058613914 bytes fdrops: 0 packets qdrops: 39626999 packets errors: 0 packets qlen: 0 packets enqueues: 1152614 dequeues: 63499 bnxt0:0:rxq:4 packets: 85096683 packets bytes: 5105801006 bytes fdrops: 0 packets qdrops: 39811883 packets errors: 0 packets qlen: 0 packets enqueues: 1152658 dequeues: 58260 bnxt0:0:rxq:5 packets: 95273701 packets bytes: 5716422060 bytes fdrops: 0 packets qdrops: 33320570 packets errors: 0 packets qlen: 0 packets enqueues: 1402623 dequeues: 54628 bnxt0:0:rxq:6 packets: 84601140 packets bytes: 5076068426 bytes fdrops: 0 packets qdrops: 39944070 packets errors: 0 packets qlen: 0 packets enqueues: 1145804 dequeues: 54198 bnxt0:0:rxq:7 packets: 84453506 packets bytes: 5067210360 bytes fdrops: 0 packets qdrops: 40490826 packets errors: 0 packets qlen: 0 packets enqueues: 1126575 dequeues: 58343 bnxt0:0:txq:0 packets: 143 packets bytes: 10068 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:1 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:2 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:3 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:4 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:5 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:6 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 bnxt0:0:txq:7 packets: 0 packets bytes: 0 bytes qdrops: 0 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 0 smc24# kstat bnxt1::: bnxt1:0:rxq:0 packets: 54 packets bytes: 7992 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 53 dequeues: 53 bnxt1:0:rxq:1 packets: 4 packets bytes: 328 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 1 dequeues: 1 bnxt1:0:rxq:2 packets: 0 packets bytes: 0 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 0 dequeues: 0 bnxt1:0:rxq:3 packets: 2 packets bytes: 196 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 2 dequeues: 2 bnxt1:0:rxq:4 packets: 0 packets bytes: 0 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 0 dequeues: 0 bnxt1:0:rxq:5 packets: 0 packets bytes: 0 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 0 dequeues: 0 bnxt1:0:rxq:6 packets: 1 packets bytes: 86 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 1 dequeues: 1 bnxt1:0:rxq:7 packets: 0 packets bytes: 0 bytes fdrops: 0 packets qdrops: 0 packets errors: 0 packets qlen: 0 packets enqueues: 0 dequeues: 0 bnxt1:0:txq:0 packets: 20619205 packets bytes: 1237152488 bytes qdrops: 19801220 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 272232 bnxt1:0:txq:1 packets: 30472450 packets bytes: 1828347000 bytes qdrops: 45418704 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 405958 bnxt1:0:txq:2 packets: 22002272 packets bytes: 1320136320 bytes qdrops: 23401454 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 293018 bnxt1:0:txq:3 packets: 22083545 packets bytes: 1325012700 bytes qdrops: 22548694 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 294115 bnxt1:0:txq:4 packets: 12880177 packets bytes: 772810620 bytes qdrops: 32383081 packets errors: 0 packets qlen: 1024 packets maxqlen: 1024 packets oactive: true oactives: 171479 bnxt1:0:txq:5 packets: 28367296 packets bytes: 1702037760 bytes qdrops: 33541714 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 377913 bnxt1:0:txq:6 packets: 23107786 packets bytes: 1386467160 bytes qdrops: 21521749 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 307432 bnxt1:0:txq:7 packets: 22844963 packets bytes: 1370697780 bytes qdrops: 21090238 packets errors: 0 packets qlen: 0 packets maxqlen: 1024 packets oactive: false oactives: 304075