From: Jonathan Gray Subject: unneeded #includes in sys/net To: tech@openbsd.org Date: Sun, 6 Jul 2025 19:06:12 +1000 diff --git sys/net/af_frame.c sys/net/af_frame.c index 4a512ea3aa2..a025023f691 100644 --- sys/net/af_frame.c +++ sys/net/af_frame.c @@ -20,15 +20,9 @@ #include #include #include -#include #include -#include -#include -#include -#include - const struct domain framedomain; /* reach over to if_ethersubr.c */ diff --git sys/net/art.c sys/net/art.c index 379767ba2eb..e9a72b2f783 100644 --- sys/net/art.c +++ sys/net/art.c @@ -32,7 +32,6 @@ #include #include #include -#include #endif #include diff --git sys/net/bpf.c sys/net/bpf.c index 8984d35435a..4a08f35d736 100644 --- sys/net/bpf.c +++ sys/net/bpf.c @@ -38,21 +38,16 @@ * @(#)bpf.c 8.2 (Berkeley) 3/28/94 */ -#include "bpfilter.h" - #include #include #include -#include +#include #include #include #include #include -#include #include -#include #include -#include #include #include #include @@ -71,9 +66,6 @@ #include #include "vlan.h" -#if NVLAN > 0 -#include -#endif #define BPF_BUFSIZE 32768 diff --git sys/net/bpf_filter.c sys/net/bpf_filter.c index d6561ec5923..27e747072a7 100644 --- sys/net/bpf_filter.c +++ sys/net/bpf_filter.c @@ -38,7 +38,6 @@ */ #include -#include #ifndef _KERNEL #include #include @@ -47,8 +46,6 @@ #include #endif -#include - #ifdef _KERNEL extern int bpf_maxbufsize; #define Static diff --git sys/net/bridgestp.c sys/net/bridgestp.c index 79d8f2c5e3d..4bcc2d4f6c8 100644 --- sys/net/bridgestp.c +++ sys/net/bridgestp.c @@ -35,20 +35,15 @@ #include #include #include -#include #include -#include -#include #include #include #include #include #include -#include #include -#include #include #include diff --git sys/net/bsd-comp.c sys/net/bsd-comp.c index cd843c7415d..e0b5057ed4f 100644 --- sys/net/bsd-comp.c +++ sys/net/bsd-comp.c @@ -43,11 +43,7 @@ #include #include #include -#include -#include -#include #include -#include #define PACKETPTR struct mbuf * #include diff --git sys/net/fq_codel.c sys/net/fq_codel.c index 5b89978e216..84962c5205d 100644 --- sys/net/fq_codel.c +++ sys/net/fq_codel.c @@ -35,7 +35,6 @@ #include #include -#include #include #include diff --git sys/net/hfsc.c sys/net/hfsc.c index 82132511517..271be79e4fa 100644 --- sys/net/hfsc.c +++ sys/net/hfsc.c @@ -46,7 +46,6 @@ #include #include #include -#include #include #include #include @@ -55,7 +54,6 @@ #include #include -#include #include #include diff --git sys/net/if.c sys/net/if.c index a236d583dea..86dd9b0cbdf 100644 --- sys/net/if.c +++ sys/net/if.c @@ -73,16 +73,13 @@ #include #include #include -#include #include #include #include #include -#include #include #include #include -#include #include /* uintptr_t */ #include #include @@ -93,11 +90,6 @@ #include #include -#include "vlan.h" -#if NVLAN > 0 -#include -#endif - #include #include #include @@ -112,7 +104,6 @@ #include #include #include -#include #include #endif @@ -128,10 +119,6 @@ #include #endif -#if NCARP > 0 -#include -#endif - #if NPF > 0 #include #endif diff --git sys/net/if_aggr.c sys/net/if_aggr.c index c0e20cbeceb..41d96977109 100644 --- sys/net/if_aggr.c +++ sys/net/if_aggr.c @@ -71,7 +71,6 @@ #include #include -#include #include #include diff --git sys/net/if_bpe.c sys/net/if_bpe.c index 0edede977f7..9b3e16e5505 100644 --- sys/net/if_bpe.c +++ sys/net/if_bpe.c @@ -20,11 +20,9 @@ #include #include -#include #include #include #include -#include #include #include #include @@ -32,9 +30,7 @@ #include #include #include -#include #include -#include #include #include diff --git sys/net/if_bridge.c sys/net/if_bridge.c index 0b12ddfd9a4..a2ba43c2492 100644 --- sys/net/if_bridge.c +++ sys/net/if_bridge.c @@ -32,7 +32,6 @@ */ #include "bpfilter.h" -#include "gif.h" #include "pf.h" #include "carp.h" #include "vlan.h" @@ -42,13 +41,11 @@ #include #include #include -#include #include #include #include #include -#include #include #include @@ -62,9 +59,7 @@ #endif #ifdef INET6 -#include #include -#include #endif #if NPF > 0 diff --git sys/net/if_etherbridge.c sys/net/if_etherbridge.c index c35c1327816..50367f17547 100644 --- sys/net/if_etherbridge.c +++ sys/net/if_etherbridge.c @@ -16,24 +16,15 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -#include "bpfilter.h" - #include #include -#include #include #include -#include #include #include #include #include -#include -#include -#include -#include -#include #include #include diff --git sys/net/if_etherip.c sys/net/if_etherip.c index 4aa54698981..45f8c81dcf0 100644 --- sys/net/if_etherip.c +++ sys/net/if_etherip.c @@ -23,15 +23,11 @@ #include #include #include -#include #include -#include #include #include -#include #include -#include #include #include diff --git sys/net/if_ethersubr.c sys/net/if_ethersubr.c index e282f054cba..25c079e7815 100644 --- sys/net/if_ethersubr.c +++ sys/net/if_ethersubr.c @@ -77,27 +77,20 @@ didn't get a copy, you may request one from . #include #include -#include #include #include -#include #include #include -#include -#include #include #include #include #include -#include #include -#include #include #include #include -#include #include #include #include @@ -128,7 +121,6 @@ didn't get a copy, you may request one from . #endif #ifdef INET6 -#include #include #endif @@ -1264,7 +1256,6 @@ ether_extract_headers(struct mbuf *m0, struct ether_extracted *ext) #include #include -#include /* * lock order is: diff --git sys/net/if_gif.c sys/net/if_gif.c index 4bb3f0b25f0..11e0bb6ae4c 100644 --- sys/net/if_gif.c +++ sys/net/if_gif.c @@ -35,23 +35,19 @@ #include #include #include -#include #include #include #include #include -#include #include -#include #include #include #include #include #ifdef INET6 -#include #include #include #endif /* INET6 */ diff --git sys/net/if_gre.c sys/net/if_gre.c index a078b86deed..1174420c847 100644 --- sys/net/if_gre.c +++ sys/net/if_gre.c @@ -52,7 +52,6 @@ #include #include #include -#include #include diff --git sys/net/if_loop.c sys/net/if_loop.c index 86258e8a9f5..d5d6e160cec 100644 --- sys/net/if_loop.c +++ sys/net/if_loop.c @@ -109,31 +109,17 @@ #include #include -#include #include #include #include #include -#include - #include #include #include -#include #include #include -#include - -#ifdef INET6 -#include -#endif - -#ifdef MPLS -#include -#endif - #if NBPFILTER > 0 #include #endif diff --git sys/net/if_media.c sys/net/if_media.c index 91c38b08390..3d7ab4f51f8 100644 --- sys/net/if_media.c +++ sys/net/if_media.c @@ -80,7 +80,6 @@ #include #include #include -#include #include #include @@ -89,7 +88,6 @@ #include #endif #include -#include /* * Compile-time options: diff --git sys/net/if_mpe.c sys/net/if_mpe.c index 6419c1130fc..3bccefffb9a 100644 --- sys/net/if_mpe.c +++ sys/net/if_mpe.c @@ -21,13 +21,11 @@ #include #include #include -#include #include #include #include #include -#include #include #include diff --git sys/net/if_mpw.c sys/net/if_mpw.c index c302143e7ac..8453daf3bf6 100644 --- sys/net/if_mpw.c +++ sys/net/if_mpw.c @@ -27,7 +27,6 @@ #include #include -#include #include #include diff --git sys/net/if_pair.c sys/net/if_pair.c index 2a772cb8b14..f4fe8f0247c 100644 --- sys/net/if_pair.c +++ sys/net/if_pair.c @@ -20,9 +20,7 @@ #include #include #include -#include #include -#include #include #include diff --git sys/net/if_pflog.c sys/net/if_pflog.c index c69333148c0..d6491070f53 100644 --- sys/net/if_pflog.c +++ sys/net/if_pflog.c @@ -35,13 +35,11 @@ */ #include "bpfilter.h" -#include "pflog.h" #include #include #include #include -#include #include #include @@ -52,14 +50,12 @@ #include #endif -#include #include #include #include #include #ifdef INET6 -#include #include #endif /* INET6 */ diff --git sys/net/if_pflow.c sys/net/if_pflow.c index b0c6eda9ba3..dd645d617a3 100644 --- sys/net/if_pflow.c +++ sys/net/if_pflow.c @@ -26,15 +26,12 @@ #include #include #include -#include #include #include #include #include #include -#include -#include #include #include #include @@ -44,15 +41,12 @@ #include #include #include -#include +#include #include #include #include -#include "bpfilter.h" -#include "pflow.h" - #define PFLOW_MINMTU \ (sizeof(struct pflow_header) + sizeof(struct pflow_flow)) diff --git sys/net/if_pfsync.c sys/net/if_pfsync.c index 9bd5fa8f5a3..a0643b9a846 100644 --- sys/net/if_pfsync.c +++ sys/net/if_pfsync.c @@ -43,7 +43,6 @@ */ #include "bpfilter.h" -#include "pfsync.h" #include "kstat.h" #include @@ -54,11 +53,9 @@ #include #include #include -#include #include #include #include -#include #include #include #include @@ -68,8 +65,6 @@ #include #include #include -#include -#include #include #include @@ -85,10 +80,8 @@ #include #ifdef INET6 -#include #include #include -#include #endif /* INET6 */ #include "carp.h" diff --git sys/net/if_ppp.c sys/net/if_ppp.c index 19df2669a00..2b58eb1e5be 100644 --- sys/net/if_ppp.c +++ sys/net/if_ppp.c @@ -114,7 +114,6 @@ #include #include #include -#include #include #include #include @@ -123,7 +122,6 @@ #include #include #include -#include #include #include diff --git sys/net/if_pppoe.c sys/net/if_pppoe.c index 09df3d0474b..fedb515237d 100644 --- sys/net/if_pppoe.c +++ sys/net/if_pppoe.c @@ -30,12 +30,10 @@ * POSSIBILITY OF SUCH DAMAGE. */ -#include "pppoe.h" #include "bpfilter.h" #include #include -#include #include #include #include @@ -50,7 +48,6 @@ #include #include #include -#include #include #if NBPFILTER > 0 diff --git sys/net/if_pppx.c sys/net/if_pppx.c index c9a2613b025..16b61599729 100644 --- sys/net/if_pppx.c +++ sys/net/if_pppx.c @@ -44,10 +44,7 @@ */ #include #include -#include -#include #include -#include #include #include #include @@ -61,20 +58,13 @@ #include #include +#include #include #include -#include #include #include #include -#include - -#ifdef INET6 -#include -#include -#include -#endif /* INET6 */ #include "bpfilter.h" #if NBPFILTER > 0 @@ -87,11 +77,9 @@ #endif #include -#include #include #ifdef PIPEX -#include #include #include #else diff --git sys/net/if_rport.c sys/net/if_rport.c index 9934db12cbe..198915e4c7c 100644 --- sys/net/if_rport.c +++ sys/net/if_rport.c @@ -21,26 +21,12 @@ #include #include #include -#include -#include #include #include #include -#include #include -#include -#include -#include -#include -#include - -#ifdef INET6 -#include -#include -#include -#endif /* INET6 */ #include "bpfilter.h" #if NBPFILTER > 0 diff --git sys/net/if_spppsubr.c sys/net/if_spppsubr.c index f23bcb29e7e..2e8b290833f 100644 --- sys/net/if_spppsubr.c +++ sys/net/if_spppsubr.c @@ -37,7 +37,6 @@ #include #include -#include #include #include #include @@ -49,7 +48,6 @@ #include #include -#include #include #include diff --git sys/net/if_tpmr.c sys/net/if_tpmr.c index 9cdba5b44ac..ca8cb28bef0 100644 --- sys/net/if_tpmr.c +++ sys/net/if_tpmr.c @@ -28,21 +28,17 @@ #include "vlan.h" #include -#include #include #include -#include #include #include #include #include -#include #include #include #include #include -#include #include #include diff --git sys/net/if_trunk.c sys/net/if_trunk.c index d4fab6aec47..eb9cda97bbb 100644 --- sys/net/if_trunk.c +++ sys/net/if_trunk.c @@ -17,7 +17,6 @@ */ #include -#include #include #include #include @@ -25,7 +24,6 @@ #include #include #include -#include #include @@ -33,7 +31,6 @@ #include #include #include -#include #include #include @@ -43,7 +40,6 @@ #include #endif -#include #include #include diff --git sys/net/if_tun.c sys/net/if_tun.c index 6e2390a955f..17dcbcf750a 100644 --- sys/net/if_tun.c +++ sys/net/if_tun.c @@ -38,7 +38,6 @@ /* #define TUN_DEBUG 9 */ #include -#include #include #include #include @@ -46,10 +45,6 @@ #include #include #include -#include -#include -#include -#include #include #include #include @@ -59,7 +54,6 @@ #include #include -#include #include #include diff --git sys/net/if_veb.c sys/net/if_veb.c index a4259b9e05a..8b3a1c75b91 100644 --- sys/net/if_veb.c +++ sys/net/if_veb.c @@ -21,7 +21,6 @@ #include "vlan.h" #include -#include #include #include #include @@ -36,18 +35,11 @@ #include #include -#include #include #include -#include #include -#ifdef INET6 -#include -#include -#endif - #if 0 && defined(IPSEC) /* * IPsec handling is disabled in veb until getting and using tdbs is mpsafe. diff --git sys/net/if_vether.c sys/net/if_vether.c index 32e61f72dce..d79da0b13d0 100644 --- sys/net/if_vether.c +++ sys/net/if_vether.c @@ -19,9 +19,7 @@ #include #include #include -#include #include -#include #include #include diff --git sys/net/if_vlan.c sys/net/if_vlan.c index 5d14abd6ca8..8f344a55ab5 100644 --- sys/net/if_vlan.c +++ sys/net/if_vlan.c @@ -48,7 +48,6 @@ */ #include -#include #include #include #include diff --git sys/net/if_vxlan.c sys/net/if_vxlan.c index 77c447d43ed..d1e5976876a 100644 --- sys/net/if_vxlan.c +++ sys/net/if_vxlan.c @@ -21,11 +21,9 @@ #include #include -#include #include #include #include -#include #include #include #include @@ -35,10 +33,6 @@ #include #include -#include -#include -#include -#include #include #include diff --git sys/net/if_wg.c sys/net/if_wg.c index b0c8369bc78..c6fd9af0940 100644 --- sys/net/if_wg.c +++ sys/net/if_wg.c @@ -41,7 +41,6 @@ #include #include -#include #include #include diff --git sys/net/ifq.c sys/net/ifq.c index cd414ef9b91..feff12ddf70 100644 --- sys/net/ifq.c +++ sys/net/ifq.c @@ -21,7 +21,6 @@ #include #include -#include #include #include #include diff --git sys/net/pf.c sys/net/pf.c index c8035add4e5..290554ff2b3 100644 --- sys/net/pf.c +++ sys/net/pf.c @@ -35,7 +35,6 @@ * */ -#include "bpfilter.h" #include "carp.h" #include "pflog.h" #include "pfsync.h" @@ -44,10 +43,8 @@ #include #include #include -#include #include #include -#include #include #include #include @@ -68,7 +65,6 @@ #include #include #include -#include #include #include #include @@ -83,16 +79,11 @@ #include #include #include -#include #endif /* INET6 */ #include #include -#if NPFLOG > 0 -#include -#endif /* NPFLOG > 0 */ - #if NPFLOW > 0 #include #endif /* NPFLOW > 0 */ diff --git sys/net/pf_if.c sys/net/pf_if.c index 046cc818be2..88e33f2ac92 100644 --- sys/net/pf_if.c +++ sys/net/pf_if.c @@ -35,11 +35,7 @@ #include #include #include -#include #include -#include -#include -#include #include #include #include @@ -49,7 +45,6 @@ #include #include -#include #include diff --git sys/net/pf_ioctl.c sys/net/pf_ioctl.c index 8ea807bf965..18b7777a4d3 100644 --- sys/net/pf_ioctl.c +++ sys/net/pf_ioctl.c @@ -45,8 +45,6 @@ #include #include #include -#include -#include #include #include #include @@ -67,14 +65,11 @@ #include #include -#include -#include #include #include #include #ifdef INET6 -#include #include #endif /* INET6 */ diff --git sys/net/pf_lb.c sys/net/pf_lb.c index 7bd6dfd607b..d428fae756b 100644 --- sys/net/pf_lb.c +++ sys/net/pf_lb.c @@ -35,28 +35,16 @@ * */ -#include "bpfilter.h" -#include "pflog.h" -#include "pfsync.h" -#include "pflow.h" - #include #include #include -#include #include -#include -#include -#include -#include -#include #include #include #include #include -#include #include #include @@ -64,12 +52,8 @@ #include #include #include -#include #include -#include -#include #include -#include #include #ifdef INET6 @@ -80,18 +64,6 @@ #include #include -#if NPFLOG > 0 -#include -#endif /* NPFLOG > 0 */ - -#if NPFLOW > 0 -#include -#endif /* NPFLOW > 0 */ - -#if NPFSYNC > 0 -#include -#endif /* NPFSYNC > 0 */ - u_int64_t pf_hash(struct pf_addr *, struct pf_addr *, struct pf_poolhashkey *, sa_family_t); int pf_get_sport(struct pf_pdesc *, struct pf_rule *, diff --git sys/net/pf_norm.c sys/net/pf_norm.c index dd44ecbc4b3..6e76ce9df6b 100644 --- sys/net/pf_norm.c +++ sys/net/pf_norm.c @@ -27,15 +27,10 @@ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "pflog.h" - #include #include #include -#include -#include #include -#include #include #include #include @@ -43,7 +38,6 @@ #include #include -#include #include #include @@ -55,11 +49,9 @@ #include #ifdef INET6 -#include #include #include #include -#include #endif /* INET6 */ #include diff --git sys/net/pf_ruleset.c sys/net/pf_ruleset.c index 34673cf2129..e793a893bc9 100644 --- sys/net/pf_ruleset.c +++ sys/net/pf_ruleset.c @@ -36,7 +36,6 @@ */ #include -#include #ifdef _KERNEL #include #include @@ -44,18 +43,9 @@ #endif /* _KERNEL */ #include -#include -#include -#include - #include #include -#ifdef INET6 -#include -#endif /* INET6 */ - - #ifdef _KERNEL #define rs_malloc(x) malloc(x, M_PF, M_WAITOK|M_CANFAIL|M_ZERO) #define rs_free(x, siz) free(x, M_PF, siz) diff --git sys/net/pf_syncookies.c sys/net/pf_syncookies.c index b6e92509dd1..7c90d8b8d93 100644 --- sys/net/pf_syncookies.c +++ sys/net/pf_syncookies.c @@ -58,48 +58,29 @@ * http://cr.yp.to/syncookies/archive (details) */ -#include "pflog.h" - #include #include #include -#include #include -#include -#include -#include -#include -#include -#include #include +#include + #include -#include -#include #include #include #include -#include #include -#include #include #include -#include +#include #include #include -#include -#include -#include -#include #include #include -#if NPFLOG > 0 -#include -#endif /* NPFLOG > 0 */ - union pf_syncookie { uint8_t cookie; struct { diff --git sys/net/pf_table.c sys/net/pf_table.c index 5e8fff8c544..90c639033eb 100644 --- sys/net/pf_table.c +++ sys/net/pf_table.c @@ -48,7 +48,6 @@ #include #ifdef INET6 -#include #include #endif /* INET6 */ diff --git sys/net/pfkeyv2.c sys/net/pfkeyv2.c index 400bbb13f69..69a9d2019e8 100644 --- sys/net/pfkeyv2.c +++ sys/net/pfkeyv2.c @@ -72,17 +72,14 @@ #include #include -#include #include #include #include #include -#include #include #include #include -#include #include #include #include diff --git sys/net/pfkeyv2_convert.c sys/net/pfkeyv2_convert.c index 47b9743ec84..d2672fd6e2c 100644 --- sys/net/pfkeyv2_convert.c +++ sys/net/pfkeyv2_convert.c @@ -96,9 +96,7 @@ #include #include #include -#include #include -#include #include #include diff --git sys/net/pipex.c sys/net/pipex.c index 570091be80f..ef2251d0f54 100644 --- sys/net/pipex.c +++ sys/net/pipex.c @@ -33,10 +33,7 @@ #include #include #include -#include -#include #include -#include #include #include #include diff --git sys/net/ppp_tty.c sys/net/ppp_tty.c index ce2131c2561..9e40d4b6400 100644 --- sys/net/ppp_tty.c +++ sys/net/ppp_tty.c @@ -106,7 +106,6 @@ #include #include #include -#include #include #include #include @@ -116,12 +115,6 @@ #include #include -#ifdef VJC -#include -#include -#include -#endif - #include #include #include diff --git sys/net/route.c sys/net/route.c index 7cdd9a49768..e19eb640b37 100644 --- sys/net/route.c +++ sys/net/route.c @@ -105,11 +105,8 @@ #include #include #include -#include #include #include -#include -#include #include #include #include @@ -2012,7 +2009,6 @@ rt_plen2mask(struct rtentry *rt, struct sockaddr_in6 *sa_mask) } #ifdef DDB -#include #include void db_print_sa(struct sockaddr *); diff --git sys/net/rtable.c sys/net/rtable.c index bc4f558a416..0c4da0ec5ef 100644 --- sys/net/rtable.c +++ sys/net/rtable.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #endif diff --git sys/net/rtsock.c sys/net/rtsock.c index d2fabc58459..892aef8c098 100644 --- sys/net/rtsock.c +++ sys/net/rtsock.c @@ -67,7 +67,6 @@ #include #include #include -#include #include #include #include @@ -84,7 +83,6 @@ #include #endif #ifdef IPSEC -#include #include #endif #ifdef BFD @@ -92,7 +90,6 @@ #endif #include -#include #include #define ROUTESNDQ 8192 diff --git sys/net/toeplitz.c sys/net/toeplitz.c index 665d334f5d8..3be5e82aa1f 100644 --- sys/net/toeplitz.c +++ sys/net/toeplitz.c @@ -53,8 +53,6 @@ #include #include -#include -#include #include diff --git sys/net/trunklacp.c sys/net/trunklacp.c index 19701a3748a..234bcb09224 100644 --- sys/net/trunklacp.c +++ sys/net/trunklacp.c @@ -33,11 +33,7 @@ #include #include #include -#include #include -#include -#include -#include #include #include #include