From: Alexander Bluhm Subject: Re: unneeded #includes in sys/netinet* To: tech@openbsd.org Date: Mon, 7 Jul 2025 14:34:00 +0200 On Mon, Jul 07, 2025 at 10:28:45PM +1000, Jonathan Gray wrote: > kernel builds on amd64, i386, arm64, sparc64 > as does make build/release on amd64 OK bluhm@ > diff --git sys/netinet/if_ether.c sys/netinet/if_ether.c > index a9dc10519d4..a1e3b737461 100644 > --- sys/netinet/if_ether.c > +++ sys/netinet/if_ether.c > @@ -45,7 +45,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -58,7 +57,6 @@ > #include > > #include > -#include > #include > #include > #if NCARP > 0 > diff --git sys/netinet/igmp.c sys/netinet/igmp.c > index 2f67490099c..4a5ef5df3c3 100644 > --- sys/netinet/igmp.c > +++ sys/netinet/igmp.c > @@ -92,8 +92,6 @@ > #include > #include > > -#include > - > #define IP_MULTICASTOPTS 0 > > int igmp_timers_are_running; /* [a] shortcut for fast timer */ > diff --git sys/netinet/in.c sys/netinet/in.c > index 7cf2cc6392c..1532e68c7f7 100644 > --- sys/netinet/in.c > +++ sys/netinet/in.c > @@ -79,9 +79,6 @@ > #include > #endif > > -#include "ether.h" > - > - > void in_socktrim(struct sockaddr_in *); > > int in_ioctl_set_ifaddr(u_long, caddr_t, struct ifnet *); > diff --git sys/netinet/in_pcb.c sys/netinet/in_pcb.c > index 5046b742192..4afde2822d3 100644 > --- sys/netinet/in_pcb.c > +++ sys/netinet/in_pcb.c > @@ -75,9 +75,7 @@ > #include > #include > #include > -#include > #include > -#include > #include > #include > > diff --git sys/netinet/in_proto.c sys/netinet/in_proto.c > index 223e2387382..66924e4c5a4 100644 > --- sys/netinet/in_proto.c > +++ sys/netinet/in_proto.c > @@ -101,12 +101,9 @@ > #include > #include > #include > -#include > > #include > #include > -#include > -#include > > #include > #include > @@ -114,10 +111,6 @@ > #include > #include > > -#ifdef INET6 > -#include > -#endif > - > #include > #include > #include > @@ -134,15 +127,10 @@ > #include > #endif > > -#ifdef INET6 > -#include > -#endif /* INET6 */ > - > #ifdef IPSEC > #include > #endif > > -#include > #include > > #include "gre.h" > diff --git sys/netinet/inet_nat64.c sys/netinet/inet_nat64.c > index 79d3c4539d3..ccbd7a5d23c 100644 > --- sys/netinet/inet_nat64.c > +++ sys/netinet/inet_nat64.c > @@ -19,9 +19,7 @@ > > #include > #include > -#ifdef _KERNEL > -#include > -#else > +#ifndef _KERNEL > #include > #endif > > diff --git sys/netinet/ip_ah.c sys/netinet/ip_ah.c > index f087ef8dccc..98502302cbc 100644 > --- sys/netinet/ip_ah.c > +++ sys/netinet/ip_ah.c > @@ -49,7 +49,6 @@ > > #include > #include > -#include > > #ifdef INET6 > #include > diff --git sys/netinet/ip_carp.c sys/netinet/ip_carp.c > index aabddd51449..986d54c9651 100644 > --- sys/netinet/ip_carp.c > +++ sys/netinet/ip_carp.c > @@ -34,18 +34,13 @@ > * > */ > > -#include "ether.h" > - > #include > #include > #include > #include > -#include > #include > #include > #include > -#include > -#include > #include > #include > #include > @@ -53,8 +48,6 @@ > #include > #include > #include > -#include > -#include > > #include > > @@ -63,7 +56,6 @@ > #include > #include > #include > -#include > > #include > > @@ -81,11 +73,6 @@ > #include > #endif > > -#include "vlan.h" > -#if NVLAN > 0 > -#include > -#endif > - > #include > > /* > diff --git sys/netinet/ip_divert.c sys/netinet/ip_divert.c > index 59f3b05a6be..dc79aa04782 100644 > --- sys/netinet/ip_divert.c > +++ sys/netinet/ip_divert.c > @@ -21,13 +21,11 @@ > #include > #include > #include > -#include > #include > > #include > #include > #include > -#include > > #include > #include > diff --git sys/netinet/ip_ecn.c sys/netinet/ip_ecn.c > index b4621a019f1..d692f319a26 100644 > --- sys/netinet/ip_ecn.c > +++ sys/netinet/ip_ecn.c > @@ -37,15 +37,9 @@ > > #include > #include > -#include > > #include > #include > - > -#ifdef INET6 > -#include > -#endif > - > #include > > /* > diff --git sys/netinet/ip_esp.c sys/netinet/ip_esp.c > index 092cbad9bde..c6d88996f3d 100644 > --- sys/netinet/ip_esp.c > +++ sys/netinet/ip_esp.c > @@ -48,7 +48,6 @@ > > #include > #include > -#include > > #ifdef INET6 > #include > diff --git sys/netinet/ip_gre.c sys/netinet/ip_gre.c > index 702e0834fa0..5b4f52e2037 100644 > --- sys/netinet/ip_gre.c > +++ sys/netinet/ip_gre.c > @@ -40,13 +40,9 @@ > #include > #include > #include > -#include > -#include > -#include > > #include > #include > -#include > > #include > #include > diff --git sys/netinet/ip_icmp.c sys/netinet/ip_icmp.c > index daf539dd20f..ab50b0398d3 100644 > --- sys/netinet/ip_icmp.c > +++ sys/netinet/ip_icmp.c > @@ -91,14 +91,9 @@ > #include > > #if NCARP > 0 > -#include > #include > #endif > > -#if NPF > 0 > -#include > -#endif > - > /* > * ICMP routines: error generation, receive packet processing, and > * routines to turnaround packets back to the originator, and > diff --git sys/netinet/ip_input.c sys/netinet/ip_input.c > index 303d97df32b..8a4c7421038 100644 > --- sys/netinet/ip_input.c > +++ sys/netinet/ip_input.c > @@ -42,7 +42,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git sys/netinet/ip_ipcomp.c sys/netinet/ip_ipcomp.c > index cb290743729..fde299a5abf 100644 > --- sys/netinet/ip_ipcomp.c > +++ sys/netinet/ip_ipcomp.c > @@ -40,7 +40,6 @@ > > #include > #include > -#include > > #ifdef INET6 > #include > diff --git sys/netinet/ip_ipip.c sys/netinet/ip_ipip.c > index fd20630cd69..3ca06817030 100644 > --- sys/netinet/ip_ipip.c > +++ sys/netinet/ip_ipip.c > @@ -53,21 +53,17 @@ > #include > #include > #include > -#include > #include > > #include > #include > -#include > +#include > +#include > #include > #include > #include > #include > > -#ifdef MROUTING > -#include > -#endif > - > #if NPF > 0 > #include > #endif > diff --git sys/netinet/ip_ipsp.c sys/netinet/ip_ipsp.c > index 31a4f3130a6..425a1554f58 100644 > --- sys/netinet/ip_ipsp.c > +++ sys/netinet/ip_ipsp.c > @@ -45,20 +45,17 @@ > #include > #include > #include > -#include > #include > #include > #include > #include > > +#include > + > #include > -#include > > #include > -#include > -#include > -#include > -#include > +#include > > #if NPF > 0 > #include > @@ -72,7 +69,6 @@ > #include > #endif > > -#include > #include > > #ifdef DDB > diff --git sys/netinet/ip_mroute.c sys/netinet/ip_mroute.c > index c03f1803aa2..63aa9321315 100644 > --- sys/netinet/ip_mroute.c > +++ sys/netinet/ip_mroute.c > @@ -60,7 +60,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git sys/netinet/ip_output.c sys/netinet/ip_output.c > index 76ee3de2517..591c0a78005 100644 > --- sys/netinet/ip_output.c > +++ sys/netinet/ip_output.c > @@ -39,9 +39,7 @@ > #include > #include > #include > -#include > #include > -#include > > #include > #include > diff --git sys/netinet/ip_spd.c sys/netinet/ip_spd.c > index 8098c42fde3..b882d7954f6 100644 > --- sys/netinet/ip_spd.c > +++ sys/netinet/ip_spd.c > @@ -24,18 +24,14 @@ > #include > #include > #include > -#include > -#include > #include > #include > > -#include > -#include > +#include > > #include > #include > -#include > -#include > +#include > #include > #include > > diff --git sys/netinet/ipsec_input.c sys/netinet/ipsec_input.c > index 458a2686c61..650d090c313 100644 > --- sys/netinet/ipsec_input.c > +++ sys/netinet/ipsec_input.c > @@ -44,14 +44,11 @@ > #include > #include > #include > -#include > #include > > #include > #include > -#include > #include > -#include > > #include > #include > @@ -69,7 +66,6 @@ > #endif > > #ifdef INET6 > -#include > #include > #include > #endif /* INET6 */ > @@ -81,9 +77,6 @@ > > #include > > -#include > -#include > - > #include "bpfilter.h" > > /* > diff --git sys/netinet/ipsec_output.c sys/netinet/ipsec_output.c > index 97d80c972bc..9d31b8954a1 100644 > --- sys/netinet/ipsec_output.c > +++ sys/netinet/ipsec_output.c > @@ -26,7 +26,6 @@ > #include > #include > #include > -#include > #include > > #include > @@ -34,7 +33,8 @@ > > #include > #include > -#include > +#include > +#include > #include > #include > > @@ -48,7 +48,6 @@ > #include > #include > > -#include > #include > > /* > diff --git sys/netinet/raw_ip.c sys/netinet/raw_ip.c > index bad3a7e6f2e..b4d91d3f6a8 100644 > --- sys/netinet/raw_ip.c > +++ sys/netinet/raw_ip.c > @@ -73,11 +73,9 @@ > #include > #include > #include > -#include > > #include > #include > -#include > > #include > #include > diff --git sys/netinet/tcp_debug.c sys/netinet/tcp_debug.c > index 751e69a8975..1110ce1ab1a 100644 > --- sys/netinet/tcp_debug.c > +++ sys/netinet/tcp_debug.c > @@ -84,10 +84,9 @@ > > #include > > -#include > #include > #include > -#include > +#include > #include > #include > #include > @@ -95,10 +94,6 @@ > #include > #include > > -#ifdef INET6 > -#include > -#endif /* INET6 */ > - > #ifdef TCPDEBUG > #include > #endif > diff --git sys/netinet/tcp_input.c sys/netinet/tcp_input.c > index 73b5803740f..c7b9c9a9d25 100644 > --- sys/netinet/tcp_input.c > +++ sys/netinet/tcp_input.c > @@ -75,7 +75,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git sys/netinet/tcp_output.c sys/netinet/tcp_output.c > index 560e4ac76f2..a35554d0992 100644 > --- sys/netinet/tcp_output.c > +++ sys/netinet/tcp_output.c > @@ -76,12 +76,9 @@ > #include > #include > #include > -#include > -#include > > #include > #include > -#include > #if NPF > 0 > #include > #endif > diff --git sys/netinet/tcp_subr.c sys/netinet/tcp_subr.c > index 6d3e6f73908..4ba5c9ab177 100644 > --- sys/netinet/tcp_subr.c > +++ sys/netinet/tcp_subr.c > @@ -73,10 +73,7 @@ > #include > #include > #include > -#include > -#include > #include > -#include > #include > > #include > diff --git sys/netinet/tcp_timer.c sys/netinet/tcp_timer.c > index cbba0b5ddf8..c7f57578691 100644 > --- sys/netinet/tcp_timer.c > +++ sys/netinet/tcp_timer.c > @@ -36,9 +36,7 @@ > #include > #include > #include > -#include > #include > -#include > #include > > #include > diff --git sys/netinet/tcp_usrreq.c sys/netinet/tcp_usrreq.c > index 188a07019d5..2c12426265b 100644 > --- sys/netinet/tcp_usrreq.c > +++ sys/netinet/tcp_usrreq.c > @@ -72,18 +72,14 @@ > #include > #include > #include > -#include > #include > #include > #include > #include > -#include > #include > -#include > > #include > #include > -#include > > #include > #include > diff --git sys/netinet/udp_usrreq.c sys/netinet/udp_usrreq.c > index 55f00f82c87..9b5f0c6e647 100644 > --- sys/netinet/udp_usrreq.c > +++ sys/netinet/udp_usrreq.c > @@ -76,14 +76,11 @@ > #include > #include > #include > -#include > #include > #include > > #include > #include > -#include > -#include > > #include > #include > @@ -110,7 +107,6 @@ > #endif > > #ifdef PIPEX > -#include > #include > #endif > > diff --git sys/netinet6/dest6.c sys/netinet6/dest6.c > index 42af42e975e..9d1901980fa 100644 > --- sys/netinet6/dest6.c > +++ sys/netinet6/dest6.c > @@ -34,16 +34,12 @@ > #include > #include > #include > -#include > -#include > -#include > > #include > > #include > #include > #include > -#include > > /* > * Destination options header processing. > diff --git sys/netinet6/frag6.c sys/netinet6/frag6.c > index e48360d0fa7..8fabaeaf811 100644 > --- sys/netinet6/frag6.c > +++ sys/netinet6/frag6.c > @@ -33,19 +33,14 @@ > #include > #include > #include > -#include > #include > -#include > -#include > #include > #include > > #include > #include > -#include > > #include > -#include > #include > #include > #include > diff --git sys/netinet6/icmp6.c sys/netinet6/icmp6.c > index f62d49d1ce6..9d273868172 100644 > --- sys/netinet6/icmp6.c > +++ sys/netinet6/icmp6.c > @@ -71,16 +71,12 @@ > #include > #include > #include > -#include > #include > -#include > -#include > > #include > #include > #include > #include > -#include > > #include > #include > diff --git sys/netinet6/in6.c sys/netinet6/in6.c > index 97f9eb383b0..0031e62a2bb 100644 > --- sys/netinet6/in6.c > +++ sys/netinet6/in6.c > @@ -73,16 +73,14 @@ > #include > #include > #include > -#include > #include > > #include > -#include > +#include > #include > #include > > #include > -#include > > #include > #include > diff --git sys/netinet6/in6_ifattach.c sys/netinet6/in6_ifattach.c > index 87f9c67be43..73d4cb997bf 100644 > --- sys/netinet6/in6_ifattach.c > +++ sys/netinet6/in6_ifattach.c > @@ -33,11 +33,6 @@ > #include > #include > #include > -#include > -#include > -#include > - > -#include > > #include > #include > @@ -49,7 +44,6 @@ > > #include > #include > -#include > #include > #include > #ifdef MROUTING > diff --git sys/netinet6/in6_pcb.c sys/netinet6/in6_pcb.c > index 77fdeb772db..0e54c2c50dc 100644 > --- sys/netinet6/in6_pcb.c > +++ sys/netinet6/in6_pcb.c > @@ -107,7 +107,6 @@ > #include > #include > #include > -#include > > #include > #include > @@ -116,7 +115,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git sys/netinet6/in6_proto.c sys/netinet6/in6_proto.c > index 6d1dd70645c..db63cd2df84 100644 > --- sys/netinet6/in6_proto.c > +++ sys/netinet6/in6_proto.c > @@ -64,19 +64,14 @@ > #include > #include > #include > -#include > #include > -#include > > #include > #include > -#include > -#include > > #include > #include > #include > -#include > #include > #include > #include > @@ -87,12 +82,9 @@ > #include > #include > #include > -#include > -#include > #include > > #include > -#include > > #include "gif.h" > #if NGIF > 0 > diff --git sys/netinet6/in6_src.c sys/netinet6/in6_src.c > index d9e0ae29f75..421d6d048ad 100644 > --- sys/netinet6/in6_src.c > +++ sys/netinet6/in6_src.c > @@ -63,12 +63,8 @@ > > #include > #include > -#include > #include > -#include > -#include > #include > -#include > > #include > #include > @@ -78,9 +74,7 @@ > #include > #include > #include > -#include > #include > -#include > > int in6_selectif(const struct in6_addr *, struct ip6_pktopts *, > struct ip6_moptions *, struct route *, struct ifnet **, u_int); > diff --git sys/netinet6/ip6_divert.c sys/netinet6/ip6_divert.c > index 86165316e70..4a4af976b45 100644 > --- sys/netinet6/ip6_divert.c > +++ sys/netinet6/ip6_divert.c > @@ -21,13 +21,10 @@ > #include > #include > #include > -#include > -#include > > #include > #include > #include > -#include > > #include > #include > diff --git sys/netinet6/ip6_forward.c sys/netinet6/ip6_forward.c > index 4ce6ce81bea..16d9001e770 100644 > --- sys/netinet6/ip6_forward.c > +++ sys/netinet6/ip6_forward.c > @@ -38,19 +38,16 @@ > #include > #include > #include > -#include > #include > > #include > #include > -#include > #include > #if NPF > 0 > #include > #endif > > #include > -#include > #include > #include > #include > @@ -58,12 +55,8 @@ > #include > #include > #include > -#include > -#include > #ifdef IPSEC > #include > -#include > -#include > #endif > > /* > diff --git sys/netinet6/ip6_id.c sys/netinet6/ip6_id.c > index 7c5277927c9..e26926368d1 100644 > --- sys/netinet6/ip6_id.c > +++ sys/netinet6/ip6_id.c > @@ -82,14 +82,8 @@ > */ > > #include > -#include > -#include > -#include > #include > > -#include > -#include > - > struct randomtab { > const int ru_bits; /* resulting bits */ > const long ru_out; /* Time after which will be reseeded */ > diff --git sys/netinet6/ip6_input.c sys/netinet6/ip6_input.c > index 54504764eb0..6492e3244e3 100644 > --- sys/netinet6/ip6_input.c > +++ sys/netinet6/ip6_input.c > @@ -71,12 +71,8 @@ > #include > #include > #include > -#include > #include > #include > -#include > -#include > -#include > #include > > #include > @@ -92,15 +88,11 @@ > #include > #include > #include > -#include > #include > #include > #include > #include > > -#include "gif.h" > -#include "bpfilter.h" > - > #ifdef MROUTING > #include > #endif > diff --git sys/netinet6/ip6_mroute.c sys/netinet6/ip6_mroute.c > index 727ea48de05..5c7add42375 100644 > --- sys/netinet6/ip6_mroute.c > +++ sys/netinet6/ip6_mroute.c > @@ -84,12 +84,9 @@ > #include > #include > #include > -#include > #include > #include > -#include > #include > -#include > #include > #include > #include > diff --git sys/netinet6/ip6_output.c sys/netinet6/ip6_output.c > index ed7db98af49..8cb1c822952 100644 > --- sys/netinet6/ip6_output.c > +++ sys/netinet6/ip6_output.c > @@ -69,7 +69,6 @@ > #include > #include > #include > -#include > #include > #include > > @@ -93,7 +92,6 @@ > #include > #include > #include > -#include > > #include > > @@ -103,8 +101,6 @@ > > #ifdef IPSEC > #include > -#include > -#include > > #ifdef ENCDEBUG > #define DPRINTF(fmt, args...) \ > diff --git sys/netinet6/mld6.c sys/netinet6/mld6.c > index df5eafaf2fc..d4f1bae6015 100644 > --- sys/netinet6/mld6.c > +++ sys/netinet6/mld6.c > @@ -70,11 +70,9 @@ > #include > #include > #include > -#include > > #include > #include > -#include > > #include > #include > diff --git sys/netinet6/nd6.c sys/netinet6/nd6.c > index 41acca1d8dd..a2b162c0d16 100644 > --- sys/netinet6/nd6.c > +++ sys/netinet6/nd6.c > @@ -38,7 +38,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -54,7 +53,6 @@ > > #include > #include > -#include > > #include > #include > diff --git sys/netinet6/nd6_nbr.c sys/netinet6/nd6_nbr.c > index 640a987b2b5..8ffc9fa19d8 100644 > --- sys/netinet6/nd6_nbr.c > +++ sys/netinet6/nd6_nbr.c > @@ -35,10 +35,6 @@ > #include > #include > #include > -#include > -#include > -#include > -#include > #include > #include > #include > diff --git sys/netinet6/nd6_rtr.c sys/netinet6/nd6_rtr.c > index ea1123cb33a..752021f335a 100644 > --- sys/netinet6/nd6_rtr.c > +++ sys/netinet6/nd6_rtr.c > @@ -32,26 +32,16 @@ > > #include > #include > -#include > -#include > #include > #include > -#include > -#include > -#include > #include > -#include > -#include > -#include > > #include > -#include > #include > #include > #include > > #include > -#include > #include > #include > #include > diff --git sys/netinet6/raw_ip6.c sys/netinet6/raw_ip6.c > index c1fa7182c1a..aa22f7b3445 100644 > --- sys/netinet6/raw_ip6.c > +++ sys/netinet6/raw_ip6.c > @@ -68,14 +68,12 @@ > #include > #include > #include > -#include > #include > #include > #include > > #include > #include > -#include > > #include > #include > @@ -87,7 +85,6 @@ > #include > #include > #include > -#include > #include > #include > > @@ -95,8 +92,6 @@ > #include > #endif > > -#include > - > /* > * Raw interface to IP6 protocol. > */ > diff --git sys/netinet6/route6.c sys/netinet6/route6.c > index 48396b0713e..985ee74ad6f 100644 > --- sys/netinet6/route6.c > +++ sys/netinet6/route6.c > @@ -32,15 +32,12 @@ > > #include > #include > -#include > #include > > #include > #include > -#include > > #include > -#include > #include > #include > > diff --git sys/netinet6/udp6_output.c sys/netinet6/udp6_output.c > index 3039e594b62..5dba125cfca 100644 > --- sys/netinet6/udp6_output.c > +++ sys/netinet6/udp6_output.c > @@ -67,19 +67,15 @@ > #include > #include > #include > -#include > #include > -#include > > #include > #include > -#include > #if NPF > 0 > #include > #endif > > #include > -#include > #include > #include > #include > @@ -87,7 +83,6 @@ > #include > #include > #include > -#include > > /* > * UDP protocol implementation.