From: Jan Klemkow <jan@openbsd.org>
Subject: Re: ice(4): add E823-L device IDs
To: tech@openbsd.org
Date: Mon, 14 Jul 2025 15:33:45 +0200

On Mon, Jul 14, 2025 at 03:05:23PM +0200, Stefan Sperling wrote:
> Add some more PCI IDs for ice(4) devices.
> I want to add support for E823-L soon.
> 
> Ok?

ok jan@

> M  sys/dev/pci/pcidevs  |  4+  0-
> 
> 1 file changed, 4 insertions(+), 0 deletions(-)
> 
> commit - 40f5da33db4ce0a8c93d973e55baf3b73b7da072
> commit + 92dd226487a35c08635c6aa383bd0d896ebab42a
> blob - d6df398a3a5051229b07eebfe188b7abd970c2ed
> blob + fb34688d7317264c0da96a1271b1a250e37524e4
> --- sys/dev/pci/pcidevs
> +++ sys/dev/pci/pcidevs
> @@ -4102,6 +4102,9 @@ product INTEL 82437MX		0x1235	82437MX
>  product INTEL 82441FX		0x1237	82441FX
>  product INTEL 82380AB		0x123c	82380AB Mobile ISA
>  product INTEL 82380FB		0x124b	82380FB Mobile
> +product INTEL E823_L_SFP	0x124d	E823-L SFP
> +product INTEL E823_L_10G	0x124e	E823-L/X557-AT
> +product INTEL E823_L_1G		0x124f	E823-L 1GbE
>  product INTEL 82439HX		0x1250	82439HX
>  product INTEL I226_LM		0x125b	I226-LM
>  product INTEL I226_V		0x125c	I226-V
> @@ -4132,6 +4135,7 @@ product INTEL 82580_COPPER_DUAL	0x1516	82580
>  product INTEL 82599_KR		0x1517	82599
>  product INTEL 82576_NS_SERDES	0x1518	82576NS
>  product INTEL 82599_T3_LOM	0x151c	82599 T3
> +product INTEL E823_L_QSFP	0x151d	E823-L QSFP
>  product INTEL I350_COPPER	0x1521	I350
>  product INTEL I350_FIBER	0x1522	I350 Fiber
>  product INTEL I350_SERDES	0x1523	I350 SerDes
> 
> 
> M  sys/dev/pci/pcidevs.h       |   5+  1-
> M  sys/dev/pci/pcidevs_data.h  |  17+  1-
> 
> 2 files changed, 22 insertions(+), 2 deletions(-)
> 
> commit - 92dd226487a35c08635c6aa383bd0d896ebab42a
> commit + 97202f87272780f3c528bac4e376a283d7f328c1
> blob - a3c8ece7b21595a11fabfa15c7fbfe7d78698a36
> blob + a466fb6218d16ccc79adb887506ec5c71bfaed5b
> --- sys/dev/pci/pcidevs.h
> +++ sys/dev/pci/pcidevs.h
> @@ -2,7 +2,7 @@
>   * THIS FILE AUTOMATICALLY GENERATED.  DO NOT EDIT.
>   *
>   * generated from:
> - *	OpenBSD: pcidevs,v 1.2104 2025/07/04 04:35:58 tb Exp 
> + *	OpenBSD: pcidevs,v 1.2105 2025/07/06 02:10:13 daniel Exp 
>   */
>  /*	$NetBSD: pcidevs,v 1.30 1997/06/24 06:20:24 thorpej Exp $	*/
>  
> @@ -4107,6 +4107,9 @@
>  #define	PCI_PRODUCT_INTEL_82441FX	0x1237		/* 82441FX */
>  #define	PCI_PRODUCT_INTEL_82380AB	0x123c		/* 82380AB Mobile ISA */
>  #define	PCI_PRODUCT_INTEL_82380FB	0x124b		/* 82380FB Mobile */
> +#define	PCI_PRODUCT_INTEL_E823_L_SFP	0x124d		/* E823-L SFP */
> +#define	PCI_PRODUCT_INTEL_E823_L_10G	0x124e		/* E823-L/X557-AT */
> +#define	PCI_PRODUCT_INTEL_E823_L_1G	0x124f		/* E823-L 1GbE */
>  #define	PCI_PRODUCT_INTEL_82439HX	0x1250		/* 82439HX */
>  #define	PCI_PRODUCT_INTEL_I226_LM	0x125b		/* I226-LM */
>  #define	PCI_PRODUCT_INTEL_I226_V	0x125c		/* I226-V */
> @@ -4137,6 +4140,7 @@
>  #define	PCI_PRODUCT_INTEL_82599_KR	0x1517		/* 82599 */
>  #define	PCI_PRODUCT_INTEL_82576_NS_SERDES	0x1518		/* 82576NS */
>  #define	PCI_PRODUCT_INTEL_82599_T3_LOM	0x151c		/* 82599 T3 */
> +#define	PCI_PRODUCT_INTEL_E823_L_QSFP	0x151d		/* E823-L QSFP */
>  #define	PCI_PRODUCT_INTEL_I350_COPPER	0x1521		/* I350 */
>  #define	PCI_PRODUCT_INTEL_I350_FIBER	0x1522		/* I350 Fiber */
>  #define	PCI_PRODUCT_INTEL_I350_SERDES	0x1523		/* I350 SerDes */
> blob - 2f71b674c7482b2935ccd6ed2546ebd80535f9bd
> blob + 730fbec42b1b284158031f4a1ebe447df8ea3582
> --- sys/dev/pci/pcidevs_data.h
> +++ sys/dev/pci/pcidevs_data.h
> @@ -2,7 +2,7 @@
>   * THIS FILE AUTOMATICALLY GENERATED.  DO NOT EDIT.
>   *
>   * generated from:
> - *	OpenBSD: pcidevs,v 1.2104 2025/07/04 04:35:58 tb Exp 
> + *	OpenBSD: pcidevs,v 1.2105 2025/07/06 02:10:13 daniel Exp 
>   */
>  
>  /*	$NetBSD: pcidevs,v 1.30 1997/06/24 06:20:24 thorpej Exp $	*/
> @@ -13756,6 +13756,18 @@ static const struct pci_known_product pci_known_produc
>  	    "82380FB Mobile",
>  	},
>  	{
> +	    PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_E823_L_SFP,
> +	    "E823-L SFP",
> +	},
> +	{
> +	    PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_E823_L_10G,
> +	    "E823-L/X557-AT",
> +	},
> +	{
> +	    PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_E823_L_1G,
> +	    "E823-L 1GbE",
> +	},
> +	{
>  	    PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_82439HX,
>  	    "82439HX",
>  	},
> @@ -13876,6 +13888,10 @@ static const struct pci_known_product pci_known_produc
>  	    "82599 T3",
>  	},
>  	{
> +	    PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_E823_L_QSFP,
> +	    "E823-L QSFP",
> +	},
> +	{
>  	    PCI_VENDOR_INTEL, PCI_PRODUCT_INTEL_I350_COPPER,
>  	    "I350",
>  	},
>