From: Jan Klemkow <jan@openbsd.org>
Subject: Re: wg(4) a bit of KNF
To: tech@openbsd.org
Date: Thu, 17 Jul 2025 14:44:15 +0200

On Thu, Jul 17, 2025 at 02:37:14PM GMT, Claudio Jeker wrote:
> KNF switch statements.
> 
> No functional change.

ok jan@

> -- 
> :wq Claudio
> 
> Index: if_wg.c
> ===================================================================
> RCS file: /cvs/src/sys/net/if_wg.c,v
> diff -u -p -r1.45 if_wg.c
> --- if_wg.c	10 Jul 2025 05:28:13 -0000	1.45
> +++ if_wg.c	17 Jul 2025 12:35:30 -0000
> @@ -617,11 +617,16 @@ wg_aip_add(struct wg_softc *sc, struct w
>  	int		 ret = 0;
>  
>  	switch (d->a_af) {
> -	case AF_INET:	root = sc->sc_aip4; break;
> +	case AF_INET:
> +		root = sc->sc_aip4;
> +		break;
>  #ifdef INET6
> -	case AF_INET6:	root = sc->sc_aip6; break;
> +	case AF_INET6:
> +		root = sc->sc_aip6;
> +		break;
>  #endif
> -	default: return EAFNOSUPPORT;
> +	default:
> +		return EAFNOSUPPORT;
>  	}
>  
>  	if ((aip = pool_get(&wg_aip_pool, PR_NOWAIT|PR_ZERO)) == NULL)
> @@ -671,11 +676,16 @@ wg_aip_remove(struct wg_softc *sc, struc
>  	int		 ret = 0;
>  
>  	switch (d->a_af) {
> -	case AF_INET:	root = sc->sc_aip4; break;
> +	case AF_INET:
> +		root = sc->sc_aip4;
> +		break;
>  #ifdef INET6
> -	case AF_INET6:	root = sc->sc_aip6; break;
> +	case AF_INET6:
> +		root = sc->sc_aip6;
> +		break;
>  #endif
> -	default: return EAFNOSUPPORT;
> +	default:
> +		return EAFNOSUPPORT;
>  	}
>  
>  	rw_enter_write(&sc->sc_aip_lock);
>