From: Alexander Bluhm <bluhm@openbsd.org>
Subject: mrt6_sysctl_mif wrong error declaration
To: tech@openbsd.org
Date: Sat, 2 Aug 2025 22:45:28 +0200

Hi,

Coverity figured out that error declaration shadows global error.
So "if (error) return (error);" further down cannot reached.

ok?

bluhm

Index: netinet6/ip6_mroute.c
===================================================================
RCS file: /data/mirror/openbsd/cvs/src/sys/netinet6/ip6_mroute.c,v
diff -u -p -r1.153 ip6_mroute.c
--- netinet6/ip6_mroute.c	25 Jul 2025 22:24:06 -0000	1.153
+++ netinet6/ip6_mroute.c	2 Aug 2025 20:41:46 -0000
@@ -348,8 +348,6 @@ mrt6_sysctl_mif(void *oldp, size_t *oldl
 
 		needed += sizeof(minfo);
 		if (where && needed <= given) {
-			int error;
-
 			error = copyout(&minfo, where, sizeof(minfo));
 			if (error)
 				break;