From: Martin Pieuchot <mpi@grenadille.net>
Subject: Re: uvm_vnp_obj_alloc
To: tech@openbsd.org
Date: Wed, 24 Sep 2025 13:47:03 +0200

On 24/09/25(Wed) 13:25, Claudio Jeker wrote:
> > Index: uvm/uvm_vnode.h
> > ===================================================================
> > RCS file: /cvs/src/sys/uvm/uvm_vnode.h,v
> > diff -u -p -r1.21 uvm_vnode.h
> > --- uvm/uvm_vnode.h	20 Oct 2022 13:31:52 -0000	1.21
> > +++ uvm/uvm_vnode.h	24 Sep 2025 09:46:04 -0000
> > @@ -94,4 +94,7 @@ struct uvm_vnode {
> >   */
> >  #define UVM_VNODE_BLOCKED (UVM_VNODE_ALOCK|UVM_VNODE_DYING|UVM_VNODE_RELKILL)
> >  
> > +void			uvm_vnp_obj_alloc(struct vnode *);
> > +void			uvm_vnp_terminate(struct vnode *);
> 
> Should uvm_vnp_terminate() really be exposed here? It is already in
> sys/vnode.h, or should uvm_vnp_obj_alloc() be added to sys/vnode.h or
> should uvm_vnp_terminate() be removed from sys/vnode.h?

I removed it from sys/vnode.h.  It is only need by the VFS.

> Apart from that OK claudio@

Thanks for the review.