From: Alexandr Nedvedicky <sashan@fastmail.net>
Subject: Re: fq_codel: align with RFC 8289 and RFC 8290 (2/2)
To: Bjorn Ketelaars <bket@openbsd.org>
Cc: tech@openbsd.org, mikeb@openbsd.org
Date: Tue, 11 Nov 2025 14:12:23 +0100

Hello,

the changes look mostly good. I think there is one finishing touch needed.
Perhaps someone with more solid background on network interfaces will either
confirm (or wave away) my concern. 

</snip>
On Mon, Oct 27, 2025 at 08:27:07PM +0100, Bjorn Ketelaars wrote:
> diff --git sys/net/fq_codel.c sys/net/fq_codel.c
> index ad8ed7022c4..af2ea41e86d 100644
> --- sys/net/fq_codel.c
> +++ sys/net/fq_codel.c
> @@ -116,6 +116,8 @@ struct fqcodel {
>  	/* stats */
>  	struct fqcodel_pktcntr	 xmit_cnt;
>  	struct fqcodel_pktcntr	 drop_cnt;
> +
> +	struct mbuf_list	 pending_drops;
>  };

    I think newly introduced list should be also dropped in
    in fqcodel_purge() function which is being called
    when interface goes down. Missing 'ml_purge(&fqc->pending_drops);'
    in fqcodel_purge() function is the only nit I could spot.

    otherwise diff looks OK to me. Let's wait if someone else will
    chime in here.

thanks and
regards
sashan