From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgpd: simplify up_generate_addpath_all
To: tech@openbsd.org
Date: Thu, 13 Nov 2025 00:17:16 +0100

On Wed, Nov 12, 2025 at 10:48:29PM +0100, Claudio Jeker wrote:
> On Wed, Nov 12, 2025 at 07:11:42PM +0100, Theo Buehler wrote:
> > On Wed, Nov 12, 2025 at 05:11:50PM +0100, Claudio Jeker wrote:
> > > up_generate_addpath_all() should just call up_generate_addpath() for the
> > > case where new and old are NULL.
> > > Doing that removes a lot of unneeded complexity which is very helpful.
> > 
> > The direct call to up_generate_addpath() helps a lot and I think the
> > additional mode checks are harmless/desirable.
> > 
> > Something isn't quite right though. You can't call up_process_prefix()
> > with new == NULL. That'll explode at frompeer = prefix_peer(p); in
> > up_test_update() unless I'm misreading something.
>  
> You are totally right. Below diff fixes this.

ok tb