From: Job Snijders <job@openbsd.org>
Subject: Re: rpki-client: factor attribute checking out of cms validation
To: Theo Buehler <tb@theobuehler.org>
Cc: tech@openbsd.org
Date: Mon, 17 Nov 2025 11:18:13 +0000

On Mon, Nov 17, 2025 at 07:05:49AM +0100, Theo Buehler wrote:
> cms_parse_validate_internal() has grown into an extremely complicated
> beast that I find hard to reason about. Upcoming refactoring will turn
> the logic upside down and inside out, so I'd like to make side effects
> or absence thereof more obvious.
> 
> Here's a first simple step that moves the attribute checking and sign
> time extraction into a helper.

OK job@