From: guenther@openbsd.org
Subject: Re: [PATCH]: Add POSIX O_CLOFORK flag
To: Theo Buehler <tb@theobuehler.org>
Cc: "Todd C. Miller" <Todd.Miller@sudo.ws>, <tech@openbsd.org>
Date: Thu, 11 Dec 2025 10:47:01 -0800

On Thu, 11 Dec 2025, Theo Buehler wrote:
> On Thu, Dec 11, 2025 at 11:23:30AM -0700, Todd C. Miller wrote:
> > On Thu, 11 Dec 2025 13:29:59 +0100, Theo Buehler wrote:
> > 
> > > Found this piece of this submission in one of my trees. Do we want this
> > > or was that omitted deliberately?
> > 
> > I think we do want the fstat.c change, but it needs a man page
> > addition as well.
> 
> thanks. like this?

almost ok guenther@


> --- fstat.c	20 Jun 2022 01:39:44 -0000	1.103
> +++ fstat.c	11 Dec 2025 18:36:17 -0000
> @@ -482,6 +482,8 @@ vtrans(struct kinfo_file *kf)
>  		strlcat(rwep, "w", sizeof rwep);
>  	if (kf->fd_ofileflags & UF_EXCLOSE)
>  		strlcat(rwep, "e", sizeof rwep);
> +	if (kf->fd_ofileflags & UF_FORKCLOSE)
> +		strlcat(rwep, "f", sizeof rwep);

The size of the rwep array needs to be bumped by one too.