From: Okan Demirmen <okan@demirmen.com>
Subject: Re: PATCH: xenocara/app/cwm: handle release of Meta (not Alt)
To: "Sven M. Hallberg" <pesco@khjk.org>
Cc: tech@openbsd.org
Date: Wed, 17 Dec 2025 13:44:09 -0500

On Wed 2025.12.17 at 13:09 +0100, Sven M. Hallberg wrote:
> Sven M. Hallberg on Tue, Mar 04 2025:
> > Sven M. Hallberg on Sat, Jul 01 2023:
> >> the attached patch solves an issue that I've had with cwm, namely that
> >> my Meta modifier would get stuck until I pressed some *other*
> >> modifier.
> 
> Ping.
> I don't see how this patch can hurt. It seems like a simple oversight.

Meta is via a modifier for Alt, Shift; so that should already be covered since
Alt is picked up by XkbKeycodeToKeysym(). What am I missing?

> Index: app/cwm/xevents.c
> ===================================================================
> RCS file: /cvs/xenocara/app/cwm/xevents.c,v
> retrieving revision 1.150
> diff -u -p -r1.150 xevents.c
> --- app/cwm/xevents.c   24 Mar 2020 14:47:29 -0000      1.150
> +++ app/cwm/xevents.c   17 Dec 2025 12:06:39 -0000
> @@ -68,8 +68,9 @@ void          (*xev_handlers[LASTEvent])(XEvent 
>                         [Expose] = xev_handle_expose,
>  };
>  
> -static KeySym modkeys[] = { XK_Alt_L, XK_Alt_R, XK_Super_L, XK_Super_R,
> -                           XK_Control_L, XK_Control_R, XK_ISO_Level3_Shift };
> +static KeySym modkeys[] = { XK_Alt_L, XK_Alt_R, XK_Meta_L, XK_Meta_R,
> +                           XK_Super_L, XK_Super_R, XK_Control_L, XK_Control_R,
> +                           XK_ISO_Level3_Shift };
>  
>  static void
>  xev_handle_maprequest(XEvent *ee)
>