From: Theo Buehler <tb@theobuehler.org>
Subject: Re: rpki-client: fix printing of ccr hashes in filemode
To: Job Snijders <job@bsd.nl>
Cc: tech@openbsd.org
Date: Tue, 30 Dec 2025 10:02:28 +0100

On Tue, Dec 30, 2025 at 08:36:11AM +0000, Job Snijders wrote:
> On Tue, Dec 30, 2025 at 05:30:27AM +0100, Theo Buehler wrote:
> > On Mon, Dec 29, 2025 at 11:16:18PM +0000, Job Snijders wrote:
> > > Filemode should print CCR hashes in the same way main(), outputheader(),
> > > and outputheader_json() do. Use a small helper function to improve
> > > readability. With this diff hash strings are aligned as follows:
> > 
> > I think the cleaner approach is changing validate_asn1_hash() to
> > use base64_encode_asn1_string() instead of hex_encode_asn1_string().
> > Then the printing function can just dump the members directly without
> > reencoding.
> 
> Ah yes, good suggestion.

ok tb