From: Dave Voutila <dv@sisu.io>
Subject: Re: vio: Fix dmamap size
To: Stefan Fritsch <sf@sfritsch.de>
Cc: tech@openbsd.org
Date: Tue, 13 Jan 2026 22:37:45 -0500

Stefan Fritsch <sf@sfritsch.de> writes:

> Hi,
>
> sc_rx_mbuf_size already includes the virtio header size, no need to add
> it again.
>
> noticed by helg@
>
> ok?

Makes sense to me looking at if_vio.c. ok dv@

>
> Cheers,
> Stefan
>
> ---
>  sys/dev/pv/if_vio.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sys/dev/pv/if_vio.c b/sys/dev/pv/if_vio.c
> index 3d9233a7999..ea54f1947f1 100644
> --- a/sys/dev/pv/if_vio.c
> +++ b/sys/dev/pv/if_vio.c
> @@ -534,8 +534,7 @@ vio_alloc_mem(struct vio_softc *sc, int tx_max_segments, bus_size_t txsize)
>
>  		for (i = 0; i < rxqsize; i++) {
>  			r = bus_dmamap_create(vsc->sc_dmat,
> -			    sc->sc_rx_mbuf_size + sc->sc_hdr_size, 2,
> -			    sc->sc_rx_mbuf_size, 0,
> +			    sc->sc_rx_mbuf_size, 2, sc->sc_rx_mbuf_size, 0,
>  			    BUS_DMA_NOWAIT | BUS_DMA_ALLOCNOW | BUS_DMA_64BIT,
>  			    &vioq->viq_rxdmamaps[i]);
>  			if (r != 0)