From: Greg Steuck Subject: Re: add another RTL8125D revision 0x68900000 To: Kevin Lo Cc: tech@openbsd.org Date: Fri, 23 Jan 2026 13:04:47 -0800 Thanks so much Kevin! Kevin Lo writes: > Hi, > > This diff adds support for RTL8125D revision 0x68900000 found on > gnezdo@'s machine. > > ok? Works like a charm, I ran an install over this driver. See the dmesg below. OK gnezdo@, with a question inside the patch body. > > Index: sys/dev/pci/if_rge.c > =================================================================== > RCS file: /cvs/src/sys/dev/pci/if_rge.c,v > diff -u -p -u -p -r1.41 if_rge.c > --- sys/dev/pci/if_rge.c 17 Nov 2025 08:59:22 -0000 1.41 > +++ sys/dev/pci/if_rge.c 23 Jan 2026 01:36:34 -0000 > @@ -97,7 +97,8 @@ void rge_phy_config_mac_r26_1(struct rg > void rge_phy_config_mac_r26_2(struct rge_softc *); > void rge_phy_config_mac_r25(struct rge_softc *); > void rge_phy_config_mac_r25b(struct rge_softc *); > -void rge_phy_config_mac_r25d(struct rge_softc *); > +void rge_phy_config_mac_r25d_1(struct rge_softc *); > +void rge_phy_config_mac_r25d_2(struct rge_softc *); > void rge_phy_config_mcu(struct rge_softc *, uint16_t); > void rge_set_macaddr(struct rge_softc *, const uint8_t *); > void rge_get_macaddr(struct rge_softc *, uint8_t *); > @@ -146,7 +147,7 @@ static const struct { > MAC_R25_MCU > }, mac_r25b_mcu[] = { > MAC_R25B_MCU > -}, mac_r25d_mcu[] = { > +}, mac_r25d_1_mcu[] = { > MAC_R25D_MCU > }; > > @@ -261,7 +262,11 @@ rge_attach(struct device *parent, struct > sc->rge_type = MAC_R26_2; > break; > case 0x68800000: > - sc->rge_type = MAC_R25D; > + sc->rge_type = MAC_R25D_1; > + printf(": RTL8125D"); > + break; > + case 0x68900000: > + sc->rge_type = MAC_R25D_2; > printf(": RTL8125D"); Do we care to give a visual indication about D1 vs D2? OpenBSD 7.8-current (GENERIC.MP) #0: Fri Jan 23 10:24:07 PST 2026 greg@home:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 21197631488 (20215MB) avail mem = 20528144384 (19577MB) random: good seed from bootblocks mpath0 at root scsibus0 at mpath0: 256 targets mainbus0 at root bios0 at mainbus0: SMBIOS rev. 3.4 @ 0xd93e2000 (51 entries) bios0: vendor American Megatrends International, LLC. version "SER50004" date 09/24/2025 bios0: AZW SER efi0 at bios0: UEFI 2.8 efi0: American Megatrends rev 0x50018 acpi0 at bios0: ACPI 6.4Undefined scope: \\_SB_.PCI0.SBRG.EC0_ Undefined scope: \\_SB_.PCI0.SBRG.EC0_ acpi0: sleep states S0 S3 S4 S5 acpi0: tables DSDT FACP MSDM SSDT SSDT FIDT MCFG HPET FPDT VFCT BGRT TPM2 SSDT CRAT CDIT SSDT SSDT SSDT SSDT SSDT WSMT APIC SSDT IVRS SSDT SSDT SSDT SSDT SSDT SSDT SSDT acpi0: wakeup devices GPP1(S4) GPP2(S4) GPP0(S4) GPP5(S4) GPP6(S4) GP18(S4) SIO1(S3) acpitimer0 at acpi0: 3579545 Hz, 32 bits acpimcfg0 at acpi0 acpimcfg0: addr 0xe0000000, bus 0-255 acpihpet0 at acpi0: 14318180 Hz acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat cpu0 at mainbus0: apid 0 (boot processor) cpu0: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu0: cpuid 1 edx=178bfbff ecx=76f8320b cpu0: cpuid 6 eax=4 ecx=1 cpu0: cpuid 7.0 ebx=219c97a9 ecx=40068c edx=10 cpu0: cpuid d.1 eax=f cpu0: cpuid 80000001 edx=2fd3fbff ecx=75c237ff cpu0: cpuid 80000007 edx=6799 cpu0: cpuid 80000008 ebx=191ef657 cpu0: cpuid 8000001F eax=1780f edx=1 cpu0: 32KB 64b/line 8-way D-cache, 32KB 64b/line 8-way I-cache, 512KB 64b/line 8-way L2 cache, 16MB 64b/line 16-way L3 cache cpu0: smt 0, core 0, package 0 mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges cpu0: apic clock running at 24MHz cpu0: mwait min=64, max=64, C-substates=1.1, IBE cpu1 at mainbus0: apid 1 (application processor) cpu1: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu1: smt 1, core 0, package 0 cpu2 at mainbus0: apid 2 (application processor) cpu2: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu2: smt 0, core 1, package 0 cpu3 at mainbus0: apid 3 (application processor) cpu3: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu3: smt 1, core 1, package 0 cpu4 at mainbus0: apid 4 (application processor) cpu4: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu4: smt 0, core 2, package 0 cpu5 at mainbus0: apid 5 (application processor) cpu5: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu5: smt 1, core 2, package 0 cpu6 at mainbus0: apid 6 (application processor) cpu6: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu6: smt 0, core 3, package 0 cpu7 at mainbus0: apid 7 (application processor) cpu7: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu7: smt 1, core 3, package 0 cpu8 at mainbus0: apid 8 (application processor) cpu8: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu8: smt 0, core 4, package 0 cpu9 at mainbus0: apid 9 (application processor) cpu9: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu9: smt 1, core 4, package 0 cpu10 at mainbus0: apid 10 (application processor) cpu10: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu10: smt 0, core 5, package 0 cpu11 at mainbus0: apid 11 (application processor) cpu11: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu11: smt 1, core 5, package 0 cpu12 at mainbus0: apid 12 (application processor) cpu12: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu12: smt 0, core 6, package 0 cpu13 at mainbus0: apid 13 (application processor) cpu13: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.02 MHz, 19-44-01, patch 0a404108 cpu13: smt 1, core 6, package 0 cpu14 at mainbus0: apid 14 (application processor) cpu14: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.00 MHz, 19-44-01, patch 0a404108 cpu14: smt 0, core 7, package 0 cpu15 at mainbus0: apid 15 (application processor) cpu15: AMD Ryzen 7 7735HS with Radeon Graphics, 3200.01 MHz, 19-44-01, patch 0a404108 cpu15: smt 1, core 7, package 0 ioapic0 at mainbus0: apid 33 pa 0xfec00000, version 21, 24 pins, can't remap ioapic1 at mainbus0: apid 34 pa 0xfec01000, version 21, 32 pins, can't remap acpiprt0 at acpi0: bus 0 (PCI0) acpiprt1 at acpi0: bus -1 (GPP1) acpiprt2 at acpi0: bus -1 (GPP2) acpiprt3 at acpi0: bus 1 (GPP0) acpiprt4 at acpi0: bus -1 (GPP3) acpiprt5 at acpi0: bus -1 (GPP4) acpiprt6 at acpi0: bus 2 (GPP5) acpiprt7 at acpi0: bus 3 (GPP6) acpiprt8 at acpi0: bus -1 (GPP7) acpiprt9 at acpi0: bus -1 (GPP8) acpiprt10 at acpi0: bus -1 (GPP9) acpiprt11 at acpi0: bus -1 (GP10) acpiprt12 at acpi0: bus 4 (GP17) acpiprt13 at acpi0: bus -1 (GP18) acpiprt14 at acpi0: bus 5 (GP19) dwiic0 at acpi0 I2CA addr 0xfedc2000/0x1000 irq 10 iic0 at dwiic0 "ANX7447" at iic0 addr 0x42 not configured acpipci0 at acpi0 PCI0: 0x00000010 0x00000011 0x00000000 acpicmos0 at acpi0 acpibtn0 at acpi0: PWRB "ACPI0010" at acpi0 not configured acpicpu0 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu1 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu2 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu3 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu4 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu5 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu6 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu7 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu8 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu9 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu10 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu11 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu12 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu13 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu14 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS acpicpu15 at acpi0: C3(0@350 io@0x415), C2(0@18 io@0x414), C1(0@1 mwait), PSS amdgpio0 at acpi0 GPIO uid 0 addr 0xfed81500/0x400 irq 7, 184 pins "AMDI0052" at acpi0 not configured tpm0 at acpi0 TPM_: unsupported TPM2 start method 2 "ACPI000E" at acpi0 not configured "PNP0C14" at acpi0 not configured acpipwrres0 at acpi0: PWRS, resource for GP11 acpipwrres1 at acpi0: PWRS, resource for SWUS acpipwrres2 at acpi0: PWRS, resource for GP12 acpipwrres3 at acpi0: PWRS, resource for SWUS acpipwrres4 at acpi0: PWRS, resource for VGA_ acpipwrres5 at acpi0: PWRS, resource for HDAU acpipwrres6 at acpi0: PWRS, resource for ACP_ acpipwrres7 at acpi0: PWRS, resource for AZAL acpipwrres8 at acpi0: PWRS, resource for XHC0 acpipwrres9 at acpi0: PWRS, resource for XHC1 acpipwrres10 at acpi0: PWRS, resource for GP17 acpipwrres11 at acpi0: PWRS, resource for XHC2 acpipwrres12 at acpi0: PWRS, resource for XHC3 acpipwrres13 at acpi0: PWRS, resource for XHC4 acpipwrres14 at acpi0: PWRS, resource for NHI0 acpipwrres15 at acpi0: PWRS, resource for NHI1 acpitz0 at acpi0 acpitz0: critical temperature is 110 degC acpivideo0 at acpi0: VGA_ acpivout0 at acpivideo0: LCD_ cpu0: 3200 MHz: speeds: 3200 1800 1600 MHz pci0 at mainbus0 bus 0 ksmn0 at pci0 dev 0 function 0 "AMD 19h/4xh Root Complex" rev 0x01 "AMD 19h/4xh IOMMU" rev 0x00 at pci0 dev 0 function 2 not configured pchb0 at pci0 dev 1 function 0 "AMD 19h/4xh Host" rev 0x01 ppb0 at pci0 dev 1 function 1 vendor "AMD", unknown product 0x14b8 rev 0x00: msi pci1 at ppb0 bus 1 nvme0 at pci1 dev 0 function 0 vendor "Crucial", unknown product 0x560b rev 0x03: msix, NVMe 1.4 nvme0: CT1000E100SSD8, firmware VDCR4014, serial 2533EADB3581 scsibus1 at nvme0: 2 targets, initiator 0 sd0 at scsibus1 targ 1 lun 0: sd0: 953869MB, 512 bytes/sector, 1953525168 sectors pchb1 at pci0 dev 2 function 0 "AMD 19h/4xh Host" rev 0x01 ppb1 at pci0 dev 2 function 1 "AMD 19h/4xh PCIE" rev 0x00: msi pci2 at ppb1 bus 2 rge0 at pci2 dev 0 function 0 "Realtek RTL8125" rev 0x0c: msix: RTL8125D, address 78:55:36:06:f9:65 ppb2 at pci0 dev 2 function 2 "AMD 19h/4xh PCIE" rev 0x00: msi pci3 at ppb2 bus 3 vendor "MediaTek", unknown product 0x7920 (class network subclass miscellaneous, rev 0x00) at pci3 dev 0 function 0 not configured pchb2 at pci0 dev 3 function 0 "AMD 19h/4xh Host" rev 0x01 pchb3 at pci0 dev 4 function 0 "AMD 19h/4xh Host" rev 0x01 pchb4 at pci0 dev 8 function 0 "AMD 19h/4xh Host" rev 0x01 ppb3 at pci0 dev 8 function 1 "AMD 19h/4xh PCIE" rev 0x10 pci4 at ppb3 bus 4 amdgpu0 at pci4 dev 0 function 0 "ATI Rembrandt" rev 0x06 drm0 at amdgpu0 amdgpu0: msi azalia0 at pci4 dev 0 function 1 "ATI Van Gogh HD Audio" rev 0x00: msi azalia0: no supported codecs ccp0 at pci4 dev 0 function 2 "AMD 17h/90h Crypto" rev 0x00 xhci0 at pci4 dev 0 function 3 "AMD 19h/4xh xHCI" rev 0x00: msix, xHCI 1.20 usb0 at xhci0: USB revision 3.0 uhub0 at usb0 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 addr 1 xhci1 at pci4 dev 0 function 4 "AMD 19h/4xh xHCI" rev 0x00: msix, xHCI 1.20 usb1 at xhci1: USB revision 3.0 uhub1 at usb1 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 addr 1 azalia1 at pci4 dev 0 function 6 "AMD 17h/1xh HD Audio" rev 0x00: msi azalia1: codecs: Realtek ALC897 audio0 at azalia1 vendor "AMD", unknown product 0x15e4 (class DASP subclass miscellaneous, rev 0x00) at pci4 dev 0 function 7 not configured ppb4 at pci0 dev 8 function 3 "AMD 19h/4xh PCIE" rev 0x10 pci5 at ppb4 bus 5 xhci2 at pci5 dev 0 function 0 "AMD 19h/4xh xHCI" rev 0x00: msix, xHCI 1.20 usb2 at xhci2: USB revision 3.0 uhub2 at usb2 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 addr 1 xhci3 at pci5 dev 0 function 3 "AMD 19h/4xh xHCI" rev 0x00: msix, xHCI 1.20 usb3 at xhci3: USB revision 3.0 uhub3 at usb3 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 addr 1 xhci4 at pci5 dev 0 function 4 "AMD 19h/4xh xHCI" rev 0x00: msix, xHCI 1.20 usb4 at xhci4: USB revision 3.0 uhub4 at usb4 configuration 1 interface 0 "AMD xHCI root hub" rev 3.00/1.00 addr 1 piixpm0 at pci0 dev 20 function 0 "AMD FCH SMBus" rev 0x71: polling iic1 at piixpm0 iic2 at piixpm0 pcib0 at pci0 dev 20 function 3 "AMD FCH LPC" rev 0x51 pchb5 at pci0 dev 24 function 0 "AMD 19h/4xh Data Fabric" rev 0x00 pchb6 at pci0 dev 24 function 1 "AMD 19h/4xh Data Fabric" rev 0x00 pchb7 at pci0 dev 24 function 2 "AMD 19h/4xh Data Fabric" rev 0x00 pchb8 at pci0 dev 24 function 3 "AMD 19h/4xh Data Fabric" rev 0x00 pchb9 at pci0 dev 24 function 4 "AMD 19h/4xh Data Fabric" rev 0x00 pchb10 at pci0 dev 24 function 5 "AMD 19h/4xh Data Fabric" rev 0x00 pchb11 at pci0 dev 24 function 6 "AMD 19h/4xh Data Fabric" rev 0x00 pchb12 at pci0 dev 24 function 7 "AMD 19h/4xh Data Fabric" rev 0x00 isa0 at pcib0 isadma0 at isa0 pckbc0 at isa0 port 0x60/5 irq 1 irq 12 pcppi0 at isa0 port 0x61 spkr0 at pcppi0 vmm0 at mainbus0: SVM/RVI efifb at mainbus0 not configured ugen0 at uhub2 port 1 "MediaTek Inc. Wireless_Device" rev 2.10/1.00 addr 2 uhub5 at uhub4 port 1 configuration 1 interface 0 "Terminus Technology USB 2.0 Hub [MTT]" rev 2.00/1.00 addr 2 uhidev0 at uhub5 port 4 configuration 1 interface 0 "AMIRA-KEYBOAR USB KEYBOARD" rev 1.10/1.13 addr 3 uhidev0: iclass 3/1 ukbd0 at uhidev0: 8 variable keys, 6 key codes wskbd0 at ukbd0: console keyboard uhidev1 at uhub5 port 4 configuration 1 interface 1 "AMIRA-KEYBOAR USB KEYBOARD" rev 1.10/1.13 addr 3 uhidev1: iclass 3/0, 7 report ids ums0 at uhidev1 reportid 1: 5 buttons, Z and W dir wsmouse0 at ums0 mux 0 ucc0 at uhidev1 reportid 3: 24 usages, 16 keys, enum wskbd1 at ucc0 mux 1 uhid0 at uhidev1 reportid 5: input=0, output=0, feature=5 uhid1 at uhidev1 reportid 6: input=0, output=0, feature=1039 uhid2 at uhidev1 reportid 7: input=0, output=0, feature=7 uaudio0 at uhub5 port 5 configuration 1 interface 1 "KTMicro KT USB Audio" rev 2.00/1.00 addr 4 uaudio0: class v1, full-speed, sync, channels: 0 play, 1 rec, 2 ctls audio1 at uaudio0 uhidev2 at uhub5 port 5 configuration 1 interface 2 "KTMicro KT USB Audio" rev 2.00/1.00 addr 4 uhidev2: iclass 3/0, 84 report ids ucc1 at uhidev2 reportid 1: 7 usages, 6 keys, enum wskbd2 at ucc1 mux 1 uhid3 at uhidev2 reportid 75: input=10, output=10, feature=0 uhid4 at uhidev2 reportid 84: input=10, output=10, feature=0 vscsi0 at root scsibus2 at vscsi0: 256 targets softraid0 at root scsibus3 at softraid0: 256 targets root on sd0a (75f15ba17795ccea.a) swap on sd0b dump on sd0b amdgpu0: YELLOW_CARP GC 10.3.3 12 CU rev 0x02 drm:pid0:generic_reg_wait *WARNING* [drm] REG_WAIT timeout 1us * 100000 tries - optc31_disable_crtc line:147 amdgpu0: 1920x1080, 32bpp wsdisplay0 at amdgpu0 mux 1: console (std, vt100 emulation), using wskbd0 wskbd1: connecting to wsdisplay0 wskbd2: connecting to wsdisplay0 wsdisplay0: screen 1-5 added (std, vt100 emulation)