From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgpd: remove some ACTION_SET types which are no longer needed
To: tech@openbsd.org
Date: Wed, 4 Feb 2026 14:16:20 +0100

On Wed, Feb 04, 2026 at 01:32:52PM +0100, Claudio Jeker wrote:
> With the filter_set & rde_filter_set_elm split there is no more need
> to split ACTION_SET_NEXTHOP and ACTION_SET_NEXTHOP_REF,
> ACTION_PFTABLE and ACTION_PFTABLE_ID, and
> ACTION_RTLABEL and ACTION_RTLABEL_ID.
> 
> This was needed because in the RDE the code was using references and ids
> and not the address / name. Now that the objects are split up the
> filter_set no longer needs to hold nh_ref and id and rde_filter_set_elm
> only uses id and nh_ref. rde_filterset_conv() takes care of the
> conversion.
> 
> Removes a lot of code that just ensures that no unexpected types sneak
> through.

ok tb