From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: Re: iked: fix ibuf leak in eap mschapv2
To: tech@openbsd.org
Date: Tue, 10 Feb 2026 13:44:49 +0100

On Tue, Feb 10, 2026 at 01:31:38PM +0100, hshoexer wrote:
> On Tue, Feb 10, 2026 at 11:34:29AM +0100, Tobias Heider wrote:
> > Start of the function allocates e = ibuf_static().
> > All the error paths free it properly except for this one.
> > 
> > ok?
> 
> ok hshoexer

ok claudio

> > commit - 96a3a92b24082e4bc76c9bd018c02a4377fcaf0d
> > blob - 7100b33fbb088a9ff3dec401f8d023c23669e651
> > file + sbin/iked/eap.c
> > --- sbin/iked/eap.c
> > +++ sbin/iked/eap.c
> > @@ -211,7 +211,7 @@ eap_challenge_request(struct iked *env, struct iked_sa
> >  		    sizeof(*ms) + strlen(name));
> >  
> >  		if ((ms = ibuf_reserve(e, sizeof(*ms))) == NULL)
> > -			return (-1);
> > +			goto done;
> >  		ms->msc_opcode = EAP_MSOPCODE_CHALLENGE;
> >  		ms->msc_id = eap->eap_id;
> >  		ms->msc_length = htobe16(sizeof(*ms) + strlen(name));
> > 
> 

-- 
:wq Claudio