From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: Re: httpd: remove empty server_http_init
To: Rafael Sadowski <rafael@sizeofvoid.org>
Cc: tech@openbsd.org
Date: Fri, 27 Feb 2026 13:18:50 +0100

On Fri, Feb 27, 2026 at 12:59:31PM +0100, Rafael Sadowski wrote:
> OK?

Sure. Ok claudio@
 
> diff --git a/usr.sbin/httpd/httpd.h b/usr.sbin/httpd/httpd.h
> index baf11d1b523..d1453d644c0 100644
> --- a/usr.sbin/httpd/httpd.h
> +++ b/usr.sbin/httpd/httpd.h
> @@ -668,7 +668,6 @@ struct server *
>  SPLAY_PROTOTYPE(client_tree, client, clt_nodes, server_client_cmp);
>  
>  /* server_http.c */
> -void	 server_http_init(struct server *);
>  void	 server_http(void);
>  int	 server_httpdesc_init(struct client *);
>  void	 server_read_http(struct bufferevent *, void *);
> diff --git a/usr.sbin/httpd/server.c b/usr.sbin/httpd/server.c
> index a38cf018d81..a82055ef9af 100644
> --- a/usr.sbin/httpd/server.c
> +++ b/usr.sbin/httpd/server.c
> @@ -415,7 +415,6 @@ server_launch(void)
>  		    srv->srv_conf.name);
>  
>  		server_tls_init(srv);
> -		server_http_init(srv);
>  
>  		log_debug("%s: running server %s", __func__,
>  		    srv->srv_conf.name);
> diff --git a/usr.sbin/httpd/server_http.c b/usr.sbin/httpd/server_http.c
> index afdb73f243f..7679003df71 100644
> --- a/usr.sbin/httpd/server_http.c
> +++ b/usr.sbin/httpd/server_http.c
> @@ -72,12 +72,6 @@ server_http(void)
>  	    sizeof(http_errors[0]), server_httperror_cmp);
>  }
>  
> -void
> -server_http_init(struct server *srv)
> -{
> -	/* nothing */
> -}
> -
>  int
>  server_httpdesc_init(struct client *clt)
>  {
> 

-- 
:wq Claudio