From: Benjamin Lee McQueen Subject: Re: typo fix in uvm_object.h To: kolipe.c@exoticsilicon.com, mcq@disroot.org Cc: tech@openbsd.org Date: Mon, 16 Mar 2026 17:02:52 -0600 > From kolipe.c@exoticsilicon.com Mon Mar 16 17:40:31 2026 > Why not fix the spacing and missing capital letters at the beginning of > sentences at the same time whilst we're changing this comment? good idea, and i'm willing to send an updated diff, but across UVM, a similar style of writing is still there - dating back to (a long time ago) it isn't the only style of writing found across UVM, but it would introduce inconsistency which likely doesn't affect readability either. unless a whole rewrite of a comment style across a subsystem _really_ impacts the overall readibility, it shouldn't be changed. -ben > > Index: uvm_object.h > > =================================================================== > > RCS file: /cvs/src/sys/uvm/uvm_object.h,v > > retrieving revision 1.30 > > diff -u -p -u -r1.30 uvm_object.h > > --- uvm_object.h 4 Sep 2022 06:49:11 -0000 1.30 > > +++ uvm_object.h 16 Mar 2026 22:11:11 -0000 > > @@ -62,7 +62,7 @@ struct uvm_object { > > * object is a kernel memory object rather than a normal one (kernel > > * memory objects don't have reference counts -- they never die). > > * > > - * this value is used to detected kernel object mappings at uvm_unmap() > > + * this value is used to detect kernel object mappings at uvm_unmap() > > * time. normally when an object is unmapped its pages eventually become > > * deactivated and then paged out and/or freed. this is not useful > > * for kernel objects... when a kernel object is unmapped we always want