From: Marc Jorge <openbsd@cypher-fox.com>
Subject: relayd: remove duplicate check on config_setrelay()
To: tech@openbsd.org
Date: Thu, 2 Apr 2026 18:18:07 +0200

Hello,

rlay->rl_tls_client_ca_fd is checked and closed twice in config_setrelay().

Marc


diff -u -p -u -r1.48 config.c
--- usr.sbin/relayd/config.c	2 Mar 2026 19:28:01 -0000	1.48
+++ usr.sbin/relayd/config.c	2 Apr 2026 16:11:46 -0000
@@ -1025,10 +1025,6 @@ config_setrelay(struct relayd *env, stru
  			cert->cert_ocsp_fd = -1;
  		}
  	}
-	if (rlay->rl_tls_client_ca_fd != -1) {
-		close(rlay->rl_tls_client_ca_fd);
-		rlay->rl_tls_client_ca_fd = -1;
-	}

  	return (0);
  }