From: Chris Cappuccio <chris@nmedia.net>
Subject: Re: acpidmar(4): Apply DTE settings
To: tech@openbsd.org
Date: Tue, 14 Apr 2026 07:27:51 -0700

hshoexer [hshoexer@yerbouti.franken.de] wrote:
> Hi,
> 
> this is a follow-up on my previous diff [1]:  When setting an AMD-Vi
> DTE entry, apply the previously recorded settings.
> 
> Thoughts? Comments? ok?
> 

It's minor, but I'd prefer reading a direct:

	if (dteset->dte & IVHD_NMIPASS)
		dte->dw5 |= DTE_NMIPASS;

over:

	if (dteset->dte & IVHD_NMIPASS)
		dte_set_nmipass(dte);
...
/* Set NMIPass */
static inline void
dte_set_nmipass(struct ivhd_dte *dte)
{
	dte->dw5 |= DTE_NMIPASS;
}