From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgpd: use unsigned int instead of uint8_t as loop iterator var
To: tech@openbsd.org
Date: Fri, 8 May 2026 13:48:25 +0200

On Fri, May 08, 2026 at 01:11:27PM +0200, Claudio Jeker wrote:
> On Fri, May 08, 2026 at 08:35:59AM +0200, Theo Buehler wrote:
> > On Fri, May 08, 2026 at 06:59:56AM +0200, Claudio Jeker wrote:
> > > Yes, most certainly. Time to grep for AID_MAX.
> > 
> > That results in this diff. The only slight complication is in the second
> > and third hunk of parse.y where I had to split the uses of aid. Where I
> > changed the type, I checked that the uses of aid and i are only as loop
> > indexing variables.
> 
> OK claudio@. I wonder if afi2aid should use u_int instead but that is a
> followup diff.

Up to you. There doesn't seem a big win in doing so, but it would be easy.
There are three instances of

	afi2aid($2, SAFI_UNICAST, &n->net.prefix.aid)

in parse.y that require a slight complication with an extra variable.