From: Theo Buehler <tb@theobuehler.org>
Subject: Re: bgplgd: fix minor issues in slowcgi handler
To: tech@openbsd.org
Date: Tue, 26 May 2026 14:51:01 +0200

On Wed, May 20, 2026 at 03:37:57PM +0200, Claudio Jeker wrote:
> Fix two issues.
> 
> Do not fail with a fatal error when a bad version message is received.
> Instead just fail, after logging the fact.
> For this switch parse_record to return ssize_t so we can return an error.
> 
> Only call exec_cgi once using the command_pid as an indicator.
> Now it is possible to fail in exec_cgi before command_pid is set but then
> the fastcgi request is also closed. I think this is good enough.

Looks right to me.

ok