From: Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject: Re: [7/7] Check error in proc_forward_imsg
To: Rafael Sadowski <rafael@sizeofvoid.org>
Cc: tech@openbsd.org
Date: Mon, 8 Jun 2026 15:47:47 +0200

On Sun, Jun 07, 2026 at 09:06:26AM +0200, Rafael Sadowski wrote:
> This is a series of commits for an imsg APIv2 rework in relayd. These
> were committed and tested individually. They can be reviewed in their
> entirety here:
> 
> gothub: https://rsadowski.gothub.org/?action=summary&headref=imsg_v2&path=relayd.git
> PR: https://codeberg.org/rsadowski/relayd/pulls/1/files
> 
> commit 6350adcb2c5bde6477eb8d4250cbaf0655138bcf
> Author: Rafael Sadowski <rafael@sizeofvoid.org>
> Date:   Sun Jun 7 08:00:59 2026 +0200
> 
>     Check failer in proc_forward_imsg
> 
> diff --git a/proc.c b/proc.c
> index d38bebd..de1f89d 100644
> --- a/proc.c
> +++ b/proc.c
> @@ -793,7 +793,7 @@ proc_composev(struct privsep *ps, enum privsep_procid id,
>  	return (proc_composev_imsg(ps, id, -1, type, -1, -1, iov, iovcnt));
>  }
>  
> -int
> +void
>  proc_forward_imsg(struct privsep *ps, struct imsg *imsg,
>      enum privsep_procid id)
>  {
> @@ -802,11 +802,9 @@ proc_forward_imsg(struct privsep *ps, struct imsg *imsg,
>  	proc_range(ps, id, &n, &m);
>  	for (; n < m; n++) {
>  		if (imsg_forward(&ps->ps_ievs[id][n].ibuf, imsg) == -1)
> -			return (-1);
> +			fatal("%s: imsg_forward", __func__);
>  		imsg_event_add(&ps->ps_ievs[id][n]);
>  	}
> -
> -	return (0);
>  }
>  
>  struct imsgbuf *
> diff --git a/relayd.h b/relayd.h
> index ac64966..bd29888 100644
> --- a/relayd.h
> +++ b/relayd.h
> @@ -1417,7 +1417,7 @@ int	 proc_composev_imsg(struct privsep *, enum privsep_procid, int,
>  	    u_int16_t, u_int32_t, int, const struct iovec *, int);
>  int	 proc_composev(struct privsep *, enum privsep_procid,
>  	    uint16_t, const struct iovec *, int);
> -int	 proc_forward_imsg(struct privsep *, struct imsg *,
> +void	proc_forward_imsg(struct privsep *, struct imsg *,
>  	    enum privsep_procid);
>  struct imsgbuf *
>  	 proc_ibuf(struct privsep *, enum privsep_procid, int);
> 

Sure.

-- 
:wq Claudio