From: Stuart Henderson Subject: Re: cal: add option to highlight the current day To: Walter Alejandro Iglesias , Theo de Raadt Cc: Johannes Thyssen Tishman , Job Snijders , , , patrick keshishian Date: Sun, 05 Jul 2026 20:00:43 +0100 You can't assume that a terminal will handle ANSI X3.64 sequences (also some users may intentionally set TERM to something dumb to avoid extra control codes in the output), which is why there is a whole subsystem for dealing with this. -- Sent from a phone, apologies for poor formatting. On 5 July 2026 19:05:17 Walter Alejandro Iglesias wrote: > On Sun, Jul 05, 2026 at 10:49:13AM -0600, Theo de Raadt wrote: >> Walter Alejandro Iglesias wrote: >> >> > On Sun, Jul 05, 2026 at 08:10:22AM -0600, Theo de Raadt wrote: >> > > + if (is_today(today, month, year)) >> > > + printf("\033[7m"); >> > > >> > > Not going to happen. >> > > >> > > >> > >> > That's from my diff, not Johannes'. I guess you don't like it because >> > it would break old terminals that doesn't support ANSI escape sequences. >> > Given Johannes have used tgetstr he is already aware of this. The above >> > is just a rookie mistake on my part. :-) >> >> "it would break old terminals that doesn't support ANSI escape sequences" >> >> Wow. >> > > If instead of mocking you explained why you don't like the above the > next time I contribute a patch to the system I'll take it into account > and we all benefit. I didn't dedicate my life to this like you did, yet > bugs were fixed thanks to me that you didn't fix. > > -- > Walter