From: Mike Larkin <mlarkin@nested.page>
Subject: Re: acpidmar(4): Move debug printf to show the actual mapping
To: tech@openbsd.org
Date: Tue, 28 Jul 2026 11:42:50 -0700

On Tue, Jul 28, 2026 at 04:04:39PM +0200, hshoexer wrote:
> Hi,
>
> trivial tweak to debug print the single mappings.  Note, this
> requires to adjust debugme() to actually print something.
>
> ok?
>

ok mlarkin

> ------------------------------------------------------------------------
> diff --git a/sys/dev/acpi/acpidmar.c b/sys/dev/acpi/acpidmar.c
> index cf18265fd09..b680b858411 100644
> --- a/sys/dev/acpi/acpidmar.c
> +++ b/sys/dev/acpi/acpidmar.c
> @@ -857,16 +857,16 @@ domain_load_map(struct domain *dom, bus_dmamap_t map, int flags, int pteflag,
>  			if (error)
>  				goto fail;
>
> +			if (debugme(dom)) {
> +				printf("  LOADMAP: %.16llx %x => %.16llx\n",
> +				    (uint64_t)seg->ds_addr,
> +				    (uint32_t)seg->ds_len, (uint64_t)res);
> +			}
> +
>  			/* Reassign DMA address */
>  			seg->ds_addr = res | (seg->ds_addr & VTD_PAGE_MASK);
>  		}
>
> -		if (debugme(dom)) {
> -			printf("  LOADMAP: %.16llx %x => %.16llx\n",
> -			    (uint64_t)seg->ds_addr, (uint32_t)seg->ds_len,
> -			    (uint64_t)res);
> -		}
> -
>  		mapped_nsegs = i + 1;
>
>  		for (idx = 0; idx < alen; idx += VTD_PAGE_SIZE) {
>