From: Simon Wollwage Subject: Re: fvwm(1): replace GPL-licensed code, fix bugs and add improvements To: David Uhden Collado Cc: op@omarpolo.com, tech@openbsd.org Date: Fri, 31 Jul 2026 23:33:19 +0900 David Uhden Collado writes: > > The truth is that I find it difficult because I've made so many > changes that I have a hard time remembering which code corresponds to > which change. However, I can divide it into two parts: rewriting the > code under the GPL and eliminating some documented bugs and compiler > warnings. I also noticed that the indentation of the source code files > was chaotic and the manual pages were not well formatted, so in my > latest version I used clang-format to indent the code, corrected the > manual pages, and removed the commented code that was not used (#if > 0). > To save you some time on the review, I would make sure that your clang-format is set to the OpenBSD style. But I wouldn't just run format over all the files, as that would increase the diff. I advise to read style(9) first. "These guidelines should be followed for all new code. In general, code can be considered "new code" when it makes up about 50% or more of the file(s) involved. This is enough to break precedents in the existing code and use the current style guidelines."