From: Alexandr Nedvedicky <sashan@fastmail.net>
Subject: Re: missing kernel lock around ip6_mforward()
To: Alexander Bluhm <bluhm@openbsd.org>
Cc: tech@openbsd.org
Date: Wed, 5 Aug 2026 09:18:21 +0200

On Tue, Aug 04, 2026 at 08:38:25PM +0200, Alexander Bluhm wrote:
> Hi,
> 
> When comparing ip_output() and ip6_output() I found a missing kernel
> lock around ip6_mforward().  It is not MP safe yet and locked
> elsewhere.
> 
> To make future comparisons easier, sync the goto bad logic between
> ip6_output() and ip6_output().
> 
> ok?
> 

    I agree with the diff. I was thinking to say 'thank you for making
    things less ugly', but saying 'thank you for making things consistent'
    is more accurate.


OK sashan