From: Jonathan Gray <jsg@jsg.id.au>
Subject: Re: em(4): simplify mac type tests
To: Jonathan Matthew <jonathan@d14n.org>
Cc: tech@openbsd.org
Date: Fri, 14 Aug 2026 15:00:48 +1000

On Fri, Aug 14, 2026 at 02:11:45PM +1000, Jonathan Matthew wrote:
> On Wed, Aug 05, 2026 at 12:19:29PM +1000, Jonathan Gray wrote:
> > reduce the number of places to change when adding mac types
> 
> Makes sense to me.  The em_clear_hw_cntrs() bit looks weird, but
> I think we've been getting that wrong since pch2lan was added, and
> this change fixes it.  ok jmatthew@

right, in Intel's FreeBSD and DPDK drivers
e1000_clear_hw_cntrs_ich8lan() doesn't read ICRXPTC and the rest

they are read for non-pch in
e1000_clear_hw_cntrs_82571()