From: Miod Vallat <miod@online.fr>
Subject: dead code tells no tales, 12/16
To: tech@openbsd.org
Date: Sun, 20 Sep 2026 21:10:43 +0000

These two routines appear to be orphaned.

Index: sys/net/pf_ioctl.c
===================================================================
RCS file: /OpenBSD/src/sys/net/pf_ioctl.c,v
diff -u -p -u -p -r1.434 pf_ioctl.c
--- sys/net/pf_ioctl.c	10 Sep 2026 12:28:04 -0000	1.434
+++ sys/net/pf_ioctl.c	20 Sep 2026 16:47:44 -0000
@@ -109,8 +109,6 @@ int			 pf_validate_range(u_int8_t, u_int
 int			 pf_rule_copyin(struct pf_rule *, struct pf_rule *);
 int			 pf_rule_checkaf(struct pf_rule *);
 u_int16_t		 pf_qname2qid(char *, int);
-void			 pf_qid2qname(u_int16_t, char *);
-void			 pf_qid_unref(u_int16_t);
 int			 pf_states_clr(struct pfioc_state_kill *);
 int			 pf_states_get(struct pfioc_states *);
 
@@ -550,18 +548,6 @@ u_int16_t
 pf_qname2qid(char *qname, int create)
 {
 	return (tagname2tag(&pf_qids, qname, create));
-}
-
-void
-pf_qid2qname(u_int16_t qid, char *p)
-{
-	tag2tagname(&pf_qids, qid, p);
-}
-
-void
-pf_qid_unref(u_int16_t qid)
-{
-	tag_unref(&pf_qids, (u_int16_t)qid);
 }
 
 int