From: Daniel Dickman <didickman@gmail.com>
Subject: silicon debug check
To: tech@openbsd.org
Date: Sun, 27 Sep 2026 23:15:25 -0400

Could the closing bracket be misplaced?

It looks like the silicon debug check only runs inside the fast strings 
block.

Index: cpu.c
===================================================================
RCS file: /home/cvs/src/sys/arch/amd64/amd64/cpu.c,v
diff -u -p -u -r1.206 cpu.c
--- cpu.c	14 May 2026 01:39:38 -0000	1.206
+++ cpu.c	28 Sep 2026 03:07:48 -0000
@@ -1253,7 +1253,8 @@ cpu_fix_msrs(struct cpu_info *ci)
 			msr |= MISC_ENABLE_FAST_STRINGS;
 			wrmsr(MSR_MISC_ENABLE, msr);
 			DPRINTF("%s: enabled fast strings\n", ci->ci_dev->dv_xname);
-	
+		}
+
 		/*
 		 * Attempt to disable Silicon Debug and lock the configuration
 		 * if it's enabled and unlocked.
@@ -1268,7 +1269,6 @@ cpu_fix_msrs(struct cpu_info *ci)
 			} else if (msr & IA32_DEBUG_INTERFACE_ENABLE)
 				printf("%s: cannot disable silicon debug\n",
 				    ci->ci_dev->dv_xname);
-			}
 		}
 	}