From: Thomas Frohwein <tfrohwein@fastmail.com>
Subject: Re: [patch] fix comment in sys/dev/usb/uhid_rdesc.h
To: Lucas de Sena <lucas@seninha.org>
Cc: openbsd-tech <tech@openbsd.org>, thfr <thfr@openbsd.org>
Date: Mon, 2 Nov 2026 14:24:12 -0700

On Mon, 22 Jun 2026 15:59:55 -0300
Lucas de Sena <lucas@seninha.org> wrote:

> Yearly bump.
> 
> I just found this while browsing mailing list archive :)
> 
> CCing thfr for he modified this file last time.

thanks, it is committed now.

> 
> On 2023-12-14, Lucas de Sena wrote:
> > Small nitpick.  Byte prefixes 0x94~0x97 denote the tag "REPORT
> > COUNT", not "REPORT SIZE".  Code is right, only the comment is
> > wrong.  See HID spec.[1]
> > 
> >                                               -- Lucas de Sena
> > 
> > [1]: https://www.usb.org/sites/default/files/hid1_11.pdf  
> 
> diff /usr/src
> commit - 718766e5b21d0efebbfde5f27c133e81e026b452
> path + /usr/src
> blob - c43bee6c1756440ed07c2bed4926871be1ff5a96
> file + sys/dev/usb/uhid_rdesc.h
> --- sys/dev/usb/uhid_rdesc.h
> +++ sys/dev/usb/uhid_rdesc.h
> @@ -249,7 +249,7 @@ static const uByte uhid_xb360gp_report_descr[] = {
>      0x26, 0xff, 0x00,	/*  LOGICAL MAXIMUM (255)
> 	*/ 0x35, 0x00,		/*  PHYSICAL MINIMUM (0)
> 	*/ 0x46, 0xff, 0x00,	/*  PHYSICAL MAXIMUM (255)
> 	*/
> -    0x95, 0x02,		/*  REPORT SIZE (2)
> 	*/
> +    0x95, 0x02,		/*  REPORT COUNT (2)
> 	*/ 0x05, 0x01,		/*  USAGE PAGE (Generic
> Desktop)	*/ 0x09, 0x32,		/*  USAGE (Z)
> 			*/ 0x09, 0x35,		/*  USAGE
> (Rz)				*/