From: Kirill A. Korinsky Subject: sys: respect vnode's contract in mknod To: OpenBSD tech Date: Sun, 08 Nov 2026 20:16:45 +0100 tech@, here a small diff which makes mkdnods to respect vnode's contract. Ok? Index: sys/miscfs/fuse/fuse_vnops.c =================================================================== RCS file: /home/cvs/src/sys/miscfs/fuse/fuse_vnops.c,v diff -u -p -r1.79 fuse_vnops.c --- sys/miscfs/fuse/fuse_vnops.c 10 Jul 2026 14:43:48 -0000 1.79 +++ sys/miscfs/fuse/fuse_vnops.c 7 Nov 2026 16:25:09 -0000 @@ -1214,9 +1214,10 @@ fusefs_mknod(void *v) * checked to see if it is an alias of an existing entry in * the inode cache. */ - vput(*vpp); + VOP_UNLOCK(*vpp); (*vpp)->v_type = VNON; vgone(*vpp); + vrele(*vpp); *vpp = NULL; out: fb_delete(fbuf); Index: sys/ufs/ext2fs/ext2fs_vnops.c =================================================================== RCS file: /home/cvs/src/sys/ufs/ext2fs/ext2fs_vnops.c,v diff -u -p -r1.95 ext2fs_vnops.c --- sys/ufs/ext2fs/ext2fs_vnops.c 1 Jun 2025 00:32:54 -0000 1.95 +++ sys/ufs/ext2fs/ext2fs_vnops.c 7 Nov 2026 16:25:09 -0000 @@ -115,9 +115,10 @@ ext2fs_mknod(void *v) * checked to see if it is an alias of an existing entry in * the inode cache. */ - vput(*vpp); + VOP_UNLOCK(*vpp); (*vpp)->v_type = VNON; vgone(*vpp); + vrele(*vpp); *vpp = NULL; return (0); } Index: sys/ufs/ufs/ufs_vnops.c =================================================================== RCS file: /home/cvs/src/sys/ufs/ufs/ufs_vnops.c,v diff -u -p -r1.165 ufs_vnops.c --- sys/ufs/ufs/ufs_vnops.c 26 May 2026 15:01:16 -0000 1.165 +++ sys/ufs/ufs/ufs_vnops.c 7 Nov 2026 16:25:09 -0000 @@ -182,9 +182,10 @@ ufs_mknod(void *v) * checked to see if it is an alias of an existing entry in * the inode cache. */ - vput(*vpp); + VOP_UNLOCK(*vpp); (*vpp)->v_type = VNON; vgone(*vpp); + vrele(*vpp); *vpp = NULL; return (0); } -- wbr, Kirill