From: Ralph Covelli Subject: Re: rpki-client: reject CustomerASID 0 in ASPAs To: tech@openbsd.org Date: Wed, 11 Nov 2026 13:37:59 -0500 Hi Theo! I agree with this change. The rtrd side does the same thing. rtrd will reject (hard fail) any ASPA import attempt where: 1) Customer AS is 0 2) The length of the Provider AS list is not mod(4) 3) The Customer AS appears in its own Provider AS list If the provider list contains AS0 and additional providers (a "mixed" ASPA) the AS0 is stripped out and we send a warning to the logger. If the provider list is too large it is truncated (max of 4096) and we send a warning to the logger. Thanks! OK rcovelli@ On 11/11/2026 12:00 PM, Theo Buehler wrote: > The customerASID element has type CAS ::= INTEGER (1..4294967295) with > section 3.2 of draft-ietf-sidrops-aspa-profile-30 explicitly saying > "The customerASID field contains a positive integer [...]". > > as_id_parse() accepts all values in [0, UINT32_MAX], so we need to > exclude 0 explicitly. > > Index: aspa.c > =================================================================== > RCS file: /cvs/src/usr.sbin/rpki-client/aspa.c,v > diff -u -p -U4 -r1.49 aspa.c > --- aspa.c 10 Nov 2026 06:53:27 -0000 1.49 > +++ aspa.c 11 Nov 2026 16:44:31 -0000 > @@ -142,8 +142,12 @@ aspa_parse_econtent(const char *fn, void > if (!as_id_parse(aspa_asn1->customerASID, &aspa->custasid)) { > warnx("%s: malformed CustomerASID", fn); > goto out; > } > + if (aspa->custasid == 0) { > + warnx("%s: CustomerASID 0 not allowed", fn); > + goto out; > + } > > if (!aspa_parse_providers(fn, aspa, aspa_asn1->providers)) > goto out; > >