Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: Alder Lake eMMC needs the same 0V quirk as Jasper/Apollo/Gemini Lake
To:
"Sven F." <sven.falempin@gmail.com>
Cc:
tech@openbsd.org
Date:
Fri, 29 Mar 2024 13:51:14 +1100

Download raw body.

Thread
On Thu, Mar 28, 2024 at 12:34:17PM -0400, Sven F. wrote:
> 
> Is there any real device working without the NOPWR0 flag ?

I've committed adding EHL to the table.  I'm curious if it still works
with this:

Index: sys/dev/sdmmc/sdhc.c
===================================================================
RCS file: /cvs/src/sys/dev/sdmmc/sdhc.c,v
diff -u -p -r1.76 sdhc.c
--- sys/dev/sdmmc/sdhc.c	1 Oct 2023 08:56:24 -0000	1.76
+++ sys/dev/sdmmc/sdhc.c	29 Mar 2024 02:37:29 -0000
@@ -594,8 +594,7 @@ sdhc_bus_power(sdmmc_chipset_handle_t sc
 	/*
 	 * Disable bus power before voltage change.
 	 */
-	if (!(hp->sc->sc_flags & SDHC_F_NOPWR0))
-		HWRITE1(hp, SDHC_POWER_CTL, 0);
+	HCLR1(hp, SDHC_POWER_CTL, SDHC_BUS_POWER);
 
 	/* If power is disabled, reset the host and return now. */
 	if (ocr == 0) {