Index | Thread | Search

From:
Jonas Bechtel <post@jbechtel.de>
Subject:
Re: [PATCH] awk: proposal: reduce utf8 scanning
To:
"Todd C. Miller" <millert@openbsd.org>
Cc:
openbsd-tech <tech@openbsd.org>
Date:
Tue, 4 Jun 2024 08:19:49 +0200

Download raw body.

Thread

On Mon, 03 Jun 2024 01:31:51 +0000
Todd C. Miller <millert@openbsd.org> wrote:

> Unfortunately, this change causes failures in the awk regression
> tests.  You need to add mb to nb if you don't scan the entire string.
> 
> The following diff passes the awk regression suite.

Glad to hear. I now looked up and found regression tests for a lot of binaries in src/regress/usr.bin, but awk isn't listed?


For mb/nb there seems to be some misunderstanding. The patches have pretty much same content, despite formatting spaces around " + " and removal of "int n" variable which I forgot.

However, when comparing patches, I discovered I have to change the wrapping options of my e-mail client which I have done now.


Best Regards
 jbechtel