Index | Thread | Search

From:
Todd C. Miller <millert@openbsd.org>
Subject:
Re: [PATCH] awk: proposal: reduce utf8 scanning
To:
Jonas Bechtel <post@jbechtel.de>
Cc:
openbsd-tech <tech@openbsd.org>
Date:
Tue, 04 Jun 2024 08:37:21 -0600

Download raw body.

Thread
On Tue, 04 Jun 2024 08:19:49 +0200, Jonas Bechtel wrote:

> Glad to hear. I now looked up and found regression tests for a lot
> of binaries in src/regress/usr.bin, but awk isn't listed?

Unfortunately, it is not.  I used the regress tests from upstream.
Someone started to adapt those tests for our regress framework but
I don't think that work was finished.

> For mb/nb there seems to be some misunderstanding. The patches have
> pretty much same content, despite formatting spaces around " + "
> and removal of "int n" variable which I forgot.

I applied the patches by hand due to the line wrapping.  It looks
like I misapplied the second one and missed the "mb+" part.

I'll commit the diff and try to get it accepted upstream.

 - todd