Index | Thread | Search

From:
Theo Buehler <tb@openbsd.org>
Subject:
Re: Page reserves
To:
tech@openbsd.org
Date:
Mon, 25 Nov 2024 19:32:51 +0100

Download raw body.

Thread
On Mon, Nov 25, 2024 at 02:44:05PM +0100, Martin Pieuchot wrote:
> Diff below removes unused 'min' values and indicates that the reserve
> for the kernel includes the one for the page daemon.
> 
> While here add a comment to document that reserving 'high' memory for
> the page daemon is not helping.
> 
> No change in behavior.

I'm ok with the removal part of the diff, but you add SWCLUSTPAGES to
uvmexp.reserve_pagedaemon and uvmexp.reserve_kernel:

> -	uvmexp.reserve_pagedaemon = 4;
> -	uvmexp.reserve_kernel = 8;
...
> +	uvmexp.reserve_pagedaemon = SWCLUSTPAGES + 4;
> +	uvmexp.reserve_kernel = uvmexp.reserve_pagedaemon + 4;

Is this intentional? And if so, how is it not a change in behavior?