On Mon, Nov 25, 2024 at 07:47:06PM +0100, Martin Pieuchot wrote:
> On 25/11/24(Mon) 19:32, Theo Buehler wrote:
> > On Mon, Nov 25, 2024 at 02:44:05PM +0100, Martin Pieuchot wrote:
> > > Diff below removes unused 'min' values and indicates that the reserve
> > > for the kernel includes the one for the page daemon.
> > > 
> > > While here add a comment to document that reserving 'high' memory for
> > > the page daemon is not helping.
> > > 
> > > No change in behavior.
> > 
> > I'm ok with the removal part of the diff, but you add SWCLUSTPAGES to
> > uvmexp.reserve_pagedaemon and uvmexp.reserve_kernel:
> 
> Thanks.
> 
> > > -	uvmexp.reserve_pagedaemon = 4;
> > > -	uvmexp.reserve_kernel = 8;
> > ...
> > > +	uvmexp.reserve_pagedaemon = SWCLUSTPAGES + 4;
> > > +	uvmexp.reserve_kernel = uvmexp.reserve_pagedaemon + 4;
> > 
> > Is this intentional? And if so, how is it not a change in behavior?
> 
> It's not.  It's a mistake.  Diff below is the correct one.

ok tb