On Sat, Jan 25, 2025 at 09:13:36AM +0100, Landry Breuil wrote:
> Le Sat, Jan 25, 2025 at 08:59:11AM +0100, Sebastien Marie a ?crit :
> > Evan Silberman <evan@jklol.net> writes:
> > > Glancing at my (I think unmodified) login.conf and then at login_cap.c
> > > it seems that it's not only the "size" type that allows "infinity" as a
> > > value. See the definitions of login_getcaptime() and login_getcapnum().
> > > (Neither function allows "inf".) So the factoid about "infinity"
> > > may need to either be repeated or stated once with reference to
> > > the size, time, and number fields.
> > 
> > You are right. I only checked strtolimit() usage, and only
> > login_getcapsize() was using it.
> > 
> > login_getcaptime() and login_getcapnum() are also using "infinity"
> > keyword for no limit, but not "inf". So there is some inconsequently.
> > 
> > the following diff adds "inf" as alias for "infinity" for
> > login_getcaptime() and login_getcapnum() as it is more forward
> > compatible than removing "inf" from login_getcapsize().
> 
> i also noted the inconsistency when quickly looking at the code, and i
> think it makes sense to allow both everywhere.
> 
> > it also adds documentation for "infinity" (but not for "inf", I am
> > unsure how to write it) for num, time and size argument type
> > description.
> 
> i wouldnt know what to do with "inf" in the manpage (whether it should
> be documented or not), but what you have here looks ok to me.
> 
> Landry
> 

i second that sentiment!
jmc